style: auto-fix lint and format

fix(releases): log instead of silently swallowing token load failures
The outer catch at releases.ts:79 silently swallowed all errors when loading widget secrets, including the case where the widget_secret table didn't exist (migration not applied). This caused tokens to silently become undefined, leading to unauthenticated API calls and rate limit errors. Now logs a warning with the itemId and error so the issue is diagnosable in server logs instead of failing silently.
2026-07-15 08:39:55 +00:00 · 2026-07-15 10:38:49 +02:00 · 2026-07-14 20:17:19 +02:00 · 2026-07-14 20:00:27 +02:00
11 changed files with 84 additions and 126 deletions
@@ -1,17 +1,9 @@
 "use client";

 import type { MutableRefObject, ReactNode } from "react";
-import { useCallback, useMemo } from "react";
-import { Group, Loader, Menu, Switch, Text, Tooltip } from "@mantine/core";
-import {
-  IconAlertTriangle,
-  IconCircleCheck,
-  IconCopy,
-  IconLayoutKanban,
-  IconRefresh,
-  IconSettings,
-  IconTrash,
-} from "@tabler/icons-react";
+import { useCallback, useEffect, useMemo, useState } from "react";
+import { Group, Loader, Menu, Switch, Text } from "@mantine/core";
+import { IconCopy, IconLayoutKanban, IconRefresh, IconSettings, IconTrash } from "@tabler/icons-react";
 import type { QueryClient, QueryKey } from "@tanstack/react-query";
 import { useIsFetching, useQueryClient } from "@tanstack/react-query";

@@ -19,12 +11,10 @@ import { clientApi } from "@homarr/api/client";
 import { useSession } from "@homarr/auth/client";
 import { useRequiredBoard } from "@homarr/boards/context";
 import { useEditMode } from "@homarr/boards/edit-mode";
-import { useTimeAgo } from "@homarr/common";
 import { useConfirmModal, useModalAction } from "@homarr/modals";
 import { useSettings } from "@homarr/settings";
 import { translateIfNecessary } from "@homarr/translation";
 import { useI18n, useScopedI18n } from "@homarr/translation/client";
-import type { TranslationFunction } from "@homarr/translation";
 import type { WidgetContextMenuAction } from "@homarr/widgets";
 import { reduceWidgetOptionsWithDefaultValues, widgetImports } from "@homarr/widgets";
 import { WidgetEditModal } from "@homarr/widgets/modals";
@@ -242,14 +232,11 @@ export const WidgetContextMenu = ({ item, widgetStateRef, children }: WidgetCont
            onClick={handleRefetch}
            disabled={isWidgetFetching}
          >
-            <Group justify="space-between" wrap="nowrap" gap="sm">
+            <Group justify="space-between" wrap="nowrap">
              {tMenu("refresh")}
-              <WidgetQueryStatus
-                queryClient={queryClient}
-                queryKey={widgetQueryKey}
-                isFetching={isWidgetFetching}
-                t={t}
-              />
+              <Text size="xs" c="dimmed">
+                <WidgetCacheAge queryClient={queryClient} queryKey={widgetQueryKey} isFetching={isWidgetFetching} />
+              </Text>
            </Group>
          </Menu.Item>
          <Menu.Item
@@ -286,65 +273,34 @@ export const WidgetContextMenu = ({ item, widgetStateRef, children }: WidgetCont
  );
 };

-interface WidgetQueryStatusProps {
+const WidgetCacheAge = ({
+  queryClient,
+  queryKey,
+  isFetching,
+}: {
  queryClient: QueryClient;
  queryKey: QueryKey;
  isFetching: boolean;
-  t: TranslationFunction;
-}
+}) => {
+  // 1s tick for "just now" → "1s ago" label transition; isFetching prop handles refetch reactivity
+  const [, setTick] = useState(0);
+  useEffect(() => {
+    const id = setInterval(() => setTick((n) => n + 1), 1000);
+    return () => clearInterval(id);
+  }, []);

-const WidgetQueryStatus = ({ queryClient, queryKey, isFetching, t }: WidgetQueryStatusProps) => {
-  const queries = queryClient.getQueryCache().findAll({ queryKey });
-  const timestamps = queries.map((query) => query.state.dataUpdatedAt).filter(Boolean);
-  const latest = timestamps.length > 0 ? Math.max(...timestamps) : 0;
-  const ageLabel = useTimeAgo(new Date(latest));
+  if (isFetching) return <Loader size={12} />;

-  if (isFetching) {
-    return (
-      <Group gap={4} wrap="nowrap">
-        <Loader size={12} />
-        <Text size="xs" c="dimmed">
-          {t("item.menu.status.loading")}
-        </Text>
-      </Group>
-    );
-  }
+  const timestamps = queryClient
+    .getQueryCache()
+    .findAll({ queryKey })
+    .map((q) => q.state.dataUpdatedAt)
+    .filter(Boolean);
+  if (timestamps.length === 0) return null;

-  if (queries.length === 0) {
-    return (
-      <Text size="xs" c="dimmed">
-        {t("item.menu.status.idle")}
-      </Text>
-    );
-  }
-
-  const hasError = queries.some((q) => q.state.status === "error");
-
-  if (hasError) {
-    const errorQuery = queries.find((q) => q.state.status === "error");
-    const errorMessage =
-      errorQuery?.state.error instanceof Error
-        ? errorQuery.state.error.message
-        : String(errorQuery?.state.error ?? "Unknown error");
-
-    return (
-      <Tooltip label={errorMessage} multiline position="left" w={250}>
-        <Group gap={4} wrap="nowrap">
-          <IconAlertTriangle size={12} color="var(--mantine-color-red-6)" />
-          <Text size="xs" c="red.6">
-            {t("item.menu.status.error")} · {ageLabel}
-          </Text>
-        </Group>
-      </Tooltip>
-    );
-  }
-
-  return (
-    <Group gap={4} wrap="nowrap">
-      <IconCircleCheck size={12} color="var(--mantine-color-green-6)" />
-      <Text size="xs" c="dimmed">
-        {t("item.menu.status.success")} · {ageLabel}
-      </Text>
-    </Group>
-  );
+  const latest = Math.max(...timestamps);
+  const seconds = Math.floor((Date.now() - latest) / 1000);
+  if (seconds < 5) return "just now";
+  if (seconds < 60) return `${seconds}s ago`;
+  return `${Math.floor(seconds / 60)}m ago`;
 };
@@ -3,6 +3,7 @@ import { escapeForRegEx } from "@tiptap/react";
 import { z } from "zod/v4";

 import { decryptSecret } from "@homarr/common/server";
+import { createLogger } from "@homarr/core/infrastructure/logs";
 import { eq } from "@homarr/db";
 import { boards, items, widgetSecrets } from "@homarr/db/schema";
 import { releaseProviderKinds } from "@homarr/definitions";
@@ -11,6 +12,8 @@ import { releasesRequestHandler } from "@homarr/request-handler/releases";
 import { createTRPCRouter, publicProcedure } from "../../trpc";
 import { throwIfActionForbiddenAsync } from "../board/board-access";

+const logger = createLogger({ module: "releasesRouter" });
+
 const formatVersionFilterRegex = (versionFilter: z.infer<typeof releaseVersionFilterSchema> | undefined) => {
  if (!versionFilter) return undefined;

@@ -71,13 +74,13 @@ export const releasesRouter = createTRPCRouter({
            for (const secret of secrets) {
              try {
                tokensByProvider.set(secret.kind, decryptSecret(secret.value));
-              } catch {
-                // Skip corrupt secrets
+              } catch (error) {
+                logger.warn("Failed to decrypt widget secret", { itemId: input.itemId, kind: secret.kind, error });
              }
            }
          }
-        } catch {
-          // Access denied or table not yet migrated -- proceed without tokens
+        } catch (error) {
+          logger.warn("Failed to load release widget tokens", { itemId: input.itemId, error });
        }
      }

@@ -153,9 +153,9 @@ export class OverseerrIntegration
      );
    } else if (pendingResults.length > 0) requests = pendingResults;
    else if (allResults.length > 0) requests = allResults;
-    else return [];
+    else return Promise.all([]);

-    const settled = await Promise.allSettled(
+    return await Promise.all(
      requests.map(async (request): Promise<MediaRequest> => {
        const information = await this.getItemInformationAsync(request.media.tmdbId, request.type);

@@ -184,10 +184,6 @@ export class OverseerrIntegration
        };
      }),
    );
-
-    return settled
-      .filter((result): result is PromiseFulfilledResult<MediaRequest> => result.status === "fulfilled")
-      .map((result) => result.value);
  }

  protected mapRequestStatus(status: UpstreamMediaRequestStatus): MediaRequestStatus {
@@ -305,10 +301,6 @@ export class OverseerrIntegration
      },
    });

-    if (!response.ok) {
-      throw new Error(`Failed to fetch ${type} information for id ${id}: ${response.status} ${response.statusText}`);
-    }
-
    if (type === "tv") {
      const series = (await response.json()) as TvInformation;
      return {
@@ -13,7 +13,6 @@ type IntegrationOfKind<TKind extends IntegrationKind> = Omit<Integration, "kind"
 interface Options<TData, TKind extends IntegrationKind, TInput extends Record<string, unknown>> {
  requestAsync: (integration: IntegrationOfKind<TKind>, input: TInput) => Promise<TData>;
  cacheTtlMs?: number;
-  fallbackToStaleOnError?: boolean;
 }

 export const createIntegrationRequestHandler = <
@@ -33,7 +32,6 @@ export const createIntegrationRequestHandler = <
      return options.requestAsync(integration, input.options);
    },
    cacheTtlMs: options.cacheTtlMs,
-    fallbackToStaleOnError: options.fallbackToStaleOnError,
  });

  return {
@@ -1,7 +1,6 @@
 interface Options<TData, TInput extends Record<string, unknown>> {
  requestAsync: (input: TInput) => Promise<TData>;
  cacheTtlMs?: number;
-  fallbackToStaleOnError?: boolean;
 }

 type CacheEntry<TData> = { data: TData; timestamp: Date; expiresAt: number };
@@ -36,6 +35,7 @@ export const createRequestHandler = <TData, TInput extends Record<string, unknow
        if (cached && Date.now() < cached.expiresAt) {
          return { data: cached.data, timestamp: cached.timestamp };
        }
+        if (cached) cache.delete(key);

        const existing = inflight.get(key);
        if (existing) return existing;
@@ -55,9 +55,6 @@ export const createRequestHandler = <TData, TInput extends Record<string, unknow
          })
          .catch((err) => {
            inflight.delete(key);
-            if (options.fallbackToStaleOnError && cached) {
-              return cached;
-            }
            throw err;
          });

@@ -13,6 +13,4 @@ export const mediaRequestListRequestHandler = createIntegrationRequestHandler<
    const integrationInstance = await createIntegrationAsync(integration);
    return await integrationInstance.getRequestsAsync();
  },
-  cacheTtlMs: 60_000,
-  fallbackToStaleOnError: true,
 });
@@ -134,7 +134,33 @@ const getGithubApi = (baseUrl: string, userAgent: string, token?: string) =>
    baseUrl,
    auth: token,
    request: { fetch: fetchWithTrustedCertificatesAsync },
-    throttle: { enabled: true },
+    throttle: {
+      enabled: true,
+      onRateLimit: (
+        retryAfter: number,
+        options: { url?: string; method?: string },
+        _octokit: unknown,
+        retryCount: number,
+      ) => {
+        logger.warn(`GitHub rate limit exceeded, retrying after ${retryAfter}s (attempt ${retryCount + 1})`, {
+          url: options.url,
+          method: options.method,
+        });
+        return retryCount < 1;
+      },
+      onSecondaryRateLimit: (
+        retryAfter: number,
+        options: { url?: string; method?: string },
+        _octokit: unknown,
+        retryCount: number,
+      ) => {
+        logger.warn(`GitHub secondary rate limit exceeded, retrying after ${retryAfter}s (attempt ${retryCount + 1})`, {
+          url: options.url,
+          method: options.method,
+        });
+        return retryCount < 1;
+      },
+    },
    userAgent,
  });

@@ -1598,16 +1598,10 @@
    },
    "menu": {
      "label": {
-        "settings": "",
+        "settings": "Settings",
        "refresh": "",
        "options": "",
        "actions": ""
-      },
-      "status": {
-        "success": "",
-        "error": "",
-        "loading": "",
-        "idle": ""
      }
    },
    "create": {
@@ -1622,12 +1622,6 @@
        "refresh": "Refresh",
        "options": "Options",
        "actions": "Actions"
-      },
-      "status": {
-        "success": "OK",
-        "error": "Error",
-        "loading": "Loading",
-        "idle": "Idle"
      }
    },
    "create": {
@@ -49,8 +49,8 @@ catalogs:
      specifier: ^2.6.0
      version: 2.6.0
    '@immich/sdk':
-      specifier: ^3.0.2
-      version: 3.0.2
+      specifier: ^3.0.1
+      version: 3.0.1
    '@jellyfin/sdk':
      specifier: ^0.13.0
      version: 0.13.0
@@ -397,8 +397,8 @@ catalogs:
      specifier: ^4.5.0
      version: 4.5.0
    lucide-react:
-      specifier: ^1.24.0
-      version: 1.24.0
+      specifier: ^1.23.0
+      version: 1.23.0
    mantine-datatable:
      specifier: ^9.3.1
      version: 9.3.1
@@ -994,7 +994,7 @@ importers:
        version: 3.10.1
      lucide-react:
        specifier: 'catalog:'
-        version: 1.24.0(react@19.2.7)
+        version: 1.23.0(react@19.2.7)
      mantine-datatable:
        specifier: 'catalog:'
        version: 9.3.1(@mantine/core@9.4.1(@mantine/hooks@9.4.1(react@19.2.7))(@types/react@19.2.17)(react-dom@19.2.7(react@19.2.7))(react@19.2.7))(@mantine/hooks@9.4.1(react@19.2.7))(clsx@2.1.1)(react-dom@19.2.7(react@19.2.7))(react@19.2.7)
@@ -1935,7 +1935,7 @@ importers:
        version: link:../validation
      '@immich/sdk':
        specifier: 'catalog:'
-        version: 3.0.2
+        version: 3.0.1
      '@jellyfin/sdk':
        specifier: 'catalog:'
        version: 0.13.0(axios@1.15.0)
@@ -2655,7 +2655,7 @@ importers:
        version: 10.4.0
      lucide-react:
        specifier: 'catalog:'
-        version: 1.24.0(react@19.2.7)
+        version: 1.23.0(react@19.2.7)
      mantine-datatable:
        specifier: 'catalog:'
        version: 9.3.1(@mantine/core@9.4.1(@mantine/hooks@9.4.1(react@19.2.7))(@types/react@19.2.17)(react-dom@19.2.7(react@19.2.7))(react@19.2.7))(@mantine/hooks@9.4.1(react@19.2.7))(clsx@2.1.1)(react-dom@19.2.7(react@19.2.7))(react@19.2.7)
@@ -5178,8 +5178,8 @@ packages:
    cpu: [x64]
    os: [win32]

-  '@immich/sdk@3.0.2':
-    resolution: {integrity: sha512-jnW8rISib4SWUX0C/1Un9Bp0FiT261v8lKrqE7U9oWaALemZ0aGDxgjnr8GpcJH1iiBaYat/Ho/qxFt/sBKcIw==}
+  '@immich/sdk@3.0.1':
+    resolution: {integrity: sha512-+iY6cd5Fc0cDIQOpXCSJHJwByaNeFj5MXzFT0xqRlXLE1G2fizoRt48BQ5eVoI64swDtwevnFIlCLYgydF/qqw==}

  '@inquirer/ansi@1.0.2':
    resolution: {integrity: sha512-S8qNSZiYzFd0wAcyG5AXCvUHC5Sr7xpZ9wZ2py9XR88jUz8wooStVx5M6dRzczbBWjic9NP7+rY0Xi7qqK/aMQ==}
@@ -11562,8 +11562,8 @@ packages:
    resolution: {integrity: sha512-DqC6n3QQ77zdFpCMASA1a3Jlb64Hv2N2DciFGkO/4L9+q/IpIAuRlKOvCXabtRW6cQf8usbmM6BE/TOPysCdIA==}
    engines: {bun: '>=1.0.0', deno: '>=1.30.0', node: '>=8.0.0'}

-  lucide-react@1.24.0:
-    resolution: {integrity: sha512-YT6mBD8lGKkg4nM39enlm94/sfJIiW0YKUT60fBy4YK8tai31ylg1VhGNWxkpSKHo9UagfnZqwIff3HTDQwXeA==}
+  lucide-react@1.23.0:
+    resolution: {integrity: sha512-38BpJcD0JhFosxHApP/BYsBetLpQFRoTRzEzstM/XCc3jsAG7wqaY1lgVwxiUe3xqYE+lNxo2PkCmYwXWrwwIw==}
    peerDependencies:
      react: ^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0

@@ -18575,7 +18575,7 @@ snapshots:
  '@img/sharp-win32-x64@0.34.5':
    optional: true

-  '@immich/sdk@3.0.2':
+  '@immich/sdk@3.0.1':
    dependencies:
      '@oazapfts/runtime': 1.2.0

@@ -25597,7 +25597,7 @@ snapshots:

  lru.min@1.1.4: {}

-  lucide-react@1.24.0(react@19.2.7):
+  lucide-react@1.23.0(react@19.2.7):
    dependencies:
      react: 19.2.7

@@ -18,7 +18,7 @@ catalog:
  "@gitbeaker/rest": ^43.8.0
  "@homarr/gridstack": ^1.12.0
  "@homarr/node-unifi": ^2.6.0
-  "@immich/sdk": ^3.0.2
+  "@immich/sdk": ^3.0.1
  "@jellyfin/sdk": ^0.13.0
  "@kubernetes/client-node": ^1.4.0
  "@modelcontextprotocol/sdk": 1.29.0
@@ -139,7 +139,7 @@ catalog:
  jsonpath-plus: ^10.4.0
  ldapts: 8.1.8
  lodash.clonedeep: ^4.5.0
-  lucide-react: ^1.24.0
+  lucide-react: ^1.23.0
  "mantine-contextmenu": ^9.3.1
  mantine-datatable: ^9.3.1
  mantine-react-table: npm:mantine-react-table-open@9.0.3
Author	SHA1	Message	Date
ajnart	2db184c1ae	style: auto-fix lint and format	2026-07-15 08:39:55 +00:00
ajnart	ae891480be	fix(releases): log instead of silently swallowing token load failures The outer catch at releases.ts:79 silently swallowed all errors when loading widget secrets, including the case where the widget_secret table didn't exist (migration not applied). This caused tokens to silently become undefined, leading to unauthenticated API calls and rate limit errors. Now logs a warning with the itemId and error so the issue is diagnosable in server logs instead of failing silently.	2026-07-15 10:38:49 +02:00
ajnart	aaff62fff2	fix(releases): return true from rate limit handlers to enable retry The octokit throttling plugin uses the return value of onRateLimit and onSecondaryRateLimit to decide whether to retry. Without returning true, rate-limited requests fail instead of being retried. Bounded to 1 retry (retryCount < 1) to prevent infinite retry loops. Addresses CodeRabbit review feedback.	2026-07-14 20:17:19 +02:00
ajnart	c01fd723ee	fix(releases): add required octokit throttling rate limit handlers When throttle is enabled in Octokit, the plugin requires onRateLimit and onSecondaryRateLimit handlers. Without them, the releases widget crashes with an error when fetching GitHub/DockerHub release data. Fixes #6309	2026-07-14 20:00:27 +02:00