fix: address PR review feedback on password suggestions

Remove redundant tests, rename requirement translations to suggestion for clearer i18n, simplify password input state and requirement display.

e2e/onboarding.spec.ts

@@ -42,37 +42,6 @@ describe("Onboarding", () => {
     await homarrContainer.stop();
   }, 60_000);
 
-  test("Credentials onboarding with special character password should be successful", async () => {
-    const { db, localMountPath } = await createSqliteDbFileAsync();
-    const homarrContainer = await createHomarrContainer({
-      mounts: {
-        "/appdata": localMountPath,
-      },
-    }).start();
-
-    const browser = await chromium.launch();
-    const context = await browser.newContext();
-    const page = await context.newPage();
-    const actions = new OnboardingActions(page, db);
-    const assertions = new OnboardingAssertions(page, db);
-
-    await page.goto(`http://${homarrContainer.getHost()}:${homarrContainer.getMappedPort(7575)}`);
-    await actions.startOnboardingAsync("scratch");
-    await actions.processUserStepAsync({
-      username: "admin",
-      password: "LoveHomarr<3",
-      confirmPassword: "LoveHomarr<3",
-    });
-    await actions.processSettingsStepAsync();
-
-    await assertions.assertFinishStepVisibleAsync();
-    await assertions.assertUserAndAdminGroupInsertedAsync("admin");
-    await assertions.assertDbOnboardingStepAsync("finish");
-
-    await browser.close();
-    await homarrContainer.stop();
-  }, 60_000);
-
   test("External provider onboarding setup should be successful", async () => {
     // Arrange
     const { db, localMountPath } = await createSqliteDbFileAsync();

packages/auth/test/security.spec.ts

@@ -53,12 +53,4 @@ describe("comparePasswordsAsync should compare passwords correctly", () => {
     // Assert
     expect(result).toBe(false);
   });
-  it("should return true for passwords with special characters like LoveHomarr<3", async () => {
-    const password = "LoveHomarr<3";
-    const hash = await hashPasswordAsync(password);
-
-    const result = await comparePasswordsAsync(password, hash);
-
-    expect(result).toBe(true);
-  });
 });

packages/translation/src/lang/ca.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Contrasenya",
-        "requirement": {
+        "suggestion": {
           "length": "Inclou com a mínim 8 caràcters",
           "lowercase": "Inclou minúscules",
           "uppercase": "Inclou majúscules",

packages/translation/src/lang/cn.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "密码",
-        "requirement": {
+        "suggestion": {
           "length": "至少包含 8 个字符",
           "lowercase": "包含小写字母",
           "uppercase": "包含大写字母",

packages/translation/src/lang/cr.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "crwdns26:0crwdne26:0",
-        "requirement": {
+        "suggestion": {
           "length": "crwdns28:0crwdne28:0",
           "lowercase": "crwdns30:0crwdne30:0",
           "uppercase": "crwdns32:0crwdne32:0",

packages/translation/src/lang/cs.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Heslo",
-        "requirement": {
+        "suggestion": {
           "length": "Obsahuje alespoň 8 znaků",
           "lowercase": "Obsahuje malé písmeno",
           "uppercase": "Obsahuje velké písmeno",

packages/translation/src/lang/da.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Adgangskode",
-        "requirement": {
+        "suggestion": {
           "length": "Inkluderer mindst 8 tegn",
           "lowercase": "Inkluderer små bogstaver",
           "uppercase": "Inkluderer store bogstaver",

packages/translation/src/lang/de-CH.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Passwort",
-        "requirement": {
+        "suggestion": {
           "length": "Enthält mindestens 8 Zeichen",
           "lowercase": "Enthält Kleinbuchstaben",
           "uppercase": "Enthält Großbuchstaben",

packages/translation/src/lang/de.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Passwort",
-        "requirement": {
+        "suggestion": {
           "length": "Enthält mindestens 8 Zeichen",
           "lowercase": "Enthält Kleinbuchstaben",
           "uppercase": "Enthält Großbuchstaben",

packages/translation/src/lang/el.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Κωδικός",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "Περιλαμβάνει πεζό γράμμα",
           "uppercase": "Περιλαμβάνει κεφαλαίο γράμμα",

packages/translation/src/lang/en-gb.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Password",
-        "requirement": {
+        "suggestion": {
           "length": "Includes a minimum of 8 characters",
           "lowercase": "Includes a lower-case letter",
           "uppercase": "Includes an upper-case letter",

packages/translation/src/lang/en.json

@@ -133,12 +133,12 @@
       "password": {
         "label": "Password",
         "suggestionsTitle": "Password suggestions",
-        "requirement": {
+        "suggestion": {
           "length": "At least 8 characters",
-          "lowercase": "Suggested: includes lowercase letter",
-          "uppercase": "Suggested: includes uppercase letter",
-          "number": "Suggested: includes number",
-          "special": "Suggested: includes special symbol"
+          "lowercase": "Includes lowercase letter",
+          "uppercase": "Includes uppercase letter",
+          "number": "Includes number",
+          "special": "Includes special symbol"
         }
       },
       "passwordConfirm": {

packages/translation/src/lang/es.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Contraseña",
-        "requirement": {
+        "suggestion": {
           "length": "Incluye al menos 8 caracteres",
           "lowercase": "Incluye al menos una letra minúscula",
           "uppercase": "Incluye al menos una letra mayúscula",

packages/translation/src/lang/et.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "",
           "uppercase": "",

packages/translation/src/lang/fr.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Mot de passe",
-        "requirement": {
+        "suggestion": {
           "length": "Contient au moins 8 caractères",
           "lowercase": "Inclut une lettre minuscule",
           "uppercase": "Inclut une lettre majuscule",

packages/translation/src/lang/he.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "סיסמה",
-        "requirement": {
+        "suggestion": {
           "length": "כולל לפחות 8 תווים",
           "lowercase": "אפשר אותיות קטנות",
           "uppercase": "אפשר אותיות גדולות",

packages/translation/src/lang/hr.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Lozinka",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "Uključuje mala slova",
           "uppercase": "Uključuje veliko slovo",

packages/translation/src/lang/hu.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Jelszó",
-        "requirement": {
+        "suggestion": {
           "length": "Tartalmazzon legalább 8 karaktert",
           "lowercase": "Tartalmazzon kisbetűt",
           "uppercase": "Tartalmazzon nagybetűt",

packages/translation/src/lang/it.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Password",
-        "requirement": {
+        "suggestion": {
           "length": "Include almeno 8 caratteri",
           "lowercase": "Include lettera minuscola",
           "uppercase": "Include lettera maiuscola",

packages/translation/src/lang/ja.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "パスワード",
-        "requirement": {
+        "suggestion": {
           "length": "少なくとも 8 文字以上を含む",
           "lowercase": "小文字を含む",
           "uppercase": "大文字を含む",

packages/translation/src/lang/ko.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "비밀번호",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "소문자 포함",
           "uppercase": "대문자 포함",

packages/translation/src/lang/lt.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Slaptažodis",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "",
           "uppercase": "",

packages/translation/src/lang/lv.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Parole",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "Ietver mazo burtu",
           "uppercase": "Ietver lielo burtu",

packages/translation/src/lang/nl.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Wachtwoord",
-        "requirement": {
+        "suggestion": {
           "length": "Bevat ten minste 8 tekens",
           "lowercase": "Inclusief kleine letter",
           "uppercase": "Inclusief hoofdletter",

packages/translation/src/lang/no.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Passord",
-        "requirement": {
+        "suggestion": {
           "length": "Inkluderer minst 8 tegn",
           "lowercase": "Inkluderer liten bokstav",
           "uppercase": "Inkluderer stor bokstav",

packages/translation/src/lang/pl.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Hasło",
-        "requirement": {
+        "suggestion": {
           "length": "Zawiera co najmniej 8 znaków",
           "lowercase": "Zawiera małą literę",
           "uppercase": "Zawiera wielką literę",

packages/translation/src/lang/pt-br.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Senha",
-        "requirement": {
+        "suggestion": {
           "length": "Inclua pelo menos 8 caracteres",
           "lowercase": "Inclui letras minúsculas",
           "uppercase": "Inclui letras maiúsculas",

packages/translation/src/lang/pt.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "",
           "uppercase": "",

packages/translation/src/lang/ro.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Parola",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "Să includă litere mici",
           "uppercase": "Să includă litere mari",

packages/translation/src/lang/ru.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Пароль",
-        "requirement": {
+        "suggestion": {
           "length": "Содержит не менее 8 символов",
           "lowercase": "Содержит строчную букву",
           "uppercase": "Содержит заглавную букву",

packages/translation/src/lang/sk.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Heslo",
-        "requirement": {
+        "suggestion": {
           "length": "Obsahuje aspoň 8 znakov",
           "lowercase": "Zahŕňa malé písmeno",
           "uppercase": "Zahŕňa veľké písmená",

packages/translation/src/lang/sl.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Geslo",
-        "requirement": {
+        "suggestion": {
           "length": "",
           "lowercase": "Vključuje male črke",
           "uppercase": "Vključuje velike tiskane črke",

packages/translation/src/lang/sv.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Lösenord",
-        "requirement": {
+        "suggestion": {
           "length": "Använd minst 8 tecken",
           "lowercase": "Använd liten bokstav",
           "uppercase": "Använd stor bokstav",

packages/translation/src/lang/tr.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Şifre",
-        "requirement": {
+        "suggestion": {
           "length": "En az 8 karakter içermeli",
           "lowercase": "Küçük harf içermeli",
           "uppercase": "Büyük harf içermeli",

packages/translation/src/lang/uk.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Пароль",
-        "requirement": {
+        "suggestion": {
           "length": "Включає принаймні 8 символів",
           "lowercase": "Включає малу літеру",
           "uppercase": "Включає велику літеру",

packages/translation/src/lang/vi.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "Mật khẩu",
-        "requirement": {
+        "suggestion": {
           "length": "Bao gồm ít nhất 8 kí tự",
           "lowercase": "Bao gồm chữ thường",
           "uppercase": "Bao gồm chữ in hoa",

packages/translation/src/lang/zh.json

@@ -132,7 +132,7 @@
       },
       "password": {
         "label": "密碼",
-        "requirement": {
+        "suggestion": {
           "length": "至少包含 8 個字符",
           "lowercase": "包含小寫字母",
           "uppercase": "包含大寫字母",

packages/ui/src/components/password-input/password-input.tsx

@@ -20,16 +20,15 @@ export const CustomPasswordInput = ({ withPasswordRequirements, ...props }: Cust
 };
 
 const WithPasswordRequirements = (props: PasswordInputProps) => {
-  const [internalValue, setInternalValue] = useState("");
-  const password = props.value ?? internalValue;
+  const [password, setPassword] = useState("");
 
   const onChange = (event: ChangeEvent<HTMLInputElement>) => {
-    setInternalValue(event.currentTarget.value);
+    setPassword(event.currentTarget.value);
     props.onChange?.(event);
   };
 
   return (
-    <PasswordRequirementsPopover password={String(password)}>
+    <PasswordRequirementsPopover password={password}>
       <PasswordInput {...props} onChange={onChange} />
     </PasswordRequirementsPopover>
   );

packages/ui/src/components/password-input/password-requirement.tsx

@@ -1,18 +1,14 @@
 import { rem, Text } from "@mantine/core";
 import { IconCheck, IconPoint } from "@tabler/icons-react";
 
-const requirementDisplay = {
-  met: { color: "teal", Icon: IconCheck },
-  unmet: { color: "dimmed", Icon: IconPoint },
-} as const;
-
-const displayKey = {
-  true: "met",
-  false: "unmet",
-} as const;
+const getRequirementDisplay = (meets: boolean) =>
+  ({
+    true: { color: "teal", Icon: IconCheck },
+    false: { color: "dimmed", Icon: IconPoint },
+  })[String(meets) as "true" | "false"];
 
 export function PasswordRequirement({ meets, label }: { meets: boolean; label: string }) {
-  const display = requirementDisplay[displayKey[String(meets) as "true" | "false"]];
+  const display = getRequirementDisplay(meets);
   const Icon = display.Icon;
 
   return (

packages/ui/src/components/password-input/password-requirements-popover.tsx

@@ -46,7 +46,7 @@ export const PasswordRequirementsPopover = ({ password, children }: PropsWithChi
 };
 
 const useRequirements = () => {
-  const t = useScopedI18n("user.field.password.requirement");
+  const t = useScopedI18n("user.field.password.suggestion");
 
   return passwordRequirements.map(({ check, value }) => ({ check, label: t(value) }));
 };

packages/validation/src/user.ts

@@ -19,7 +19,7 @@ export const passwordRequirements = [
   { check: regexCheck(/[$&+,:;=?@#|'<>.^*()%!\-~`"_/\\[\]{}]/), value: "special" },
 ] satisfies {
   check: (value: string) => boolean;
-  value: keyof TranslationObject["user"]["field"]["password"]["requirement"];
+  value: keyof TranslationObject["user"]["field"]["password"]["suggestion"];
 }[];
 
 export const userPasswordSchema = z.string().min(8).max(255);