fix(analytics): restrict publishing to every week (#5028)

apps/nextjs/src/app/[locale]/manage/tools/tasks/_components/tasks-table.tsx

@@ -117,6 +117,8 @@ const createColumns = (
     header: tTasks("field.interval.label"),
     size: 200,
     Cell({ row }) {
+      if (row.original.preventCustomInterval) return null;
+
       const handleIntervalChange = (newCron: string | null) => {
         if (!newCron || newCron === row.original.cron) return;
 

apps/tasks/src/job-manager.ts

@@ -31,6 +31,10 @@ export class JobManager implements IJobManager {
     if (!validateCron(cron)) {
       throw new Error(`Invalid cron expression: ${cron}`);
     }
+    if (job.preventCustomInterval && cron !== job.cronExpression) {
+      throw new Error(`Custom cron expressions are not allowed for job ${name}`);
+    }
+
     await this.updateConfigurationAsync(name, { cronExpression: cron });
     await this.jobGroup.getTask(name)?.destroy();
 
@@ -100,7 +104,13 @@ export class JobManager implements IJobManager {
   }
 
   public async getAllAsync(): Promise<
-    { name: JobGroupKeys; cron: string; preventManualExecution: boolean; isEnabled: boolean }[]
+    {
+      name: JobGroupKeys;
+      cron: string;
+      preventManualExecution: boolean;
+      preventCustomInterval: boolean;
+      isEnabled: boolean;
+    }[]
   > {
     const configurations = await this.db.query.cronJobConfigurations.findMany();
 
@@ -110,6 +120,7 @@ export class JobManager implements IJobManager {
         name,
         cron: config?.cronExpression ?? job.cronExpression,
         preventManualExecution: job.preventManualExecution,
+        preventCustomInterval: job.preventCustomInterval,
         isEnabled: config?.isEnabled ?? true,
       };
     });

packages/cron-job-api/src/index.ts

@@ -17,7 +17,15 @@ export interface IJobManager {
   updateIntervalAsync(name: JobGroupKeys, cron: string): Promise<void>;
   disableAsync(name: JobGroupKeys): Promise<void>;
   enableAsync(name: JobGroupKeys): Promise<void>;
-  getAllAsync(): Promise<{ name: JobGroupKeys; cron: string; preventManualExecution: boolean; isEnabled: boolean }[]>;
+  getAllAsync(): Promise<
+    {
+      name: JobGroupKeys;
+      cron: string;
+      preventManualExecution: boolean;
+      preventCustomInterval: boolean;
+      isEnabled: boolean;
+    }[]
+  >;
 }
 
 const t = initTRPC

packages/cron-jobs-core/src/creator.ts

@@ -19,6 +19,7 @@ export interface CreateCronJobCreatorOptions<TAllowedNames extends string> {
 interface CreateCronJobOptions {
   runOnStart?: boolean;
   preventManualExecution?: boolean;
+  preventCustomInterval?: boolean;
   expectedMaximumDurationInMillis?: number;
   beforeStart?: () => MaybePromise<void>;
 }
@@ -78,14 +79,14 @@ const createCallback = <TAllowedNames extends string, TName extends TAllowedName
           where: (cronJobConfigurations, { eq }) => eq(cronJobConfigurations.name, name),
         });
 
-        const scheduledTask = createTask(
-          configuration?.cronExpression ?? defaultCronExpression,
-          () => void catchingCallbackAsync(),
-          {
-            name,
-            timezone: creatorOptions.timezone,
-          },
-        );
+        const cronExpression = options.preventCustomInterval
+          ? defaultCronExpression
+          : (configuration?.cronExpression ?? defaultCronExpression);
+
+        const scheduledTask = createTask(cronExpression, () => void catchingCallbackAsync(), {
+          name,
+          timezone: creatorOptions.timezone,
+        });
         creatorOptions.logger.logDebug("The scheduled task for cron job was created", {
           name,
           cronExpression: defaultCronExpression,
@@ -114,6 +115,7 @@ const createCallback = <TAllowedNames extends string, TName extends TAllowedName
         await catchingCallbackAsync();
       },
       preventManualExecution: options.preventManualExecution ?? false,
+      preventCustomInterval: options.preventCustomInterval ?? false,
     };
   };
 };

packages/cron-jobs/src/jobs/analytics.ts

@@ -9,6 +9,7 @@ import { createCronJob } from "../lib";
 export const analyticsJob = createCronJob("analytics", EVERY_WEEK, {
   runOnStart: true,
   preventManualExecution: true,
+  preventCustomInterval: true,
 }).withCallback(async () => {
   if (env.NO_EXTERNAL_CONNECTION) return;
   const analyticSetting = await getServerSettingByKeyAsync(db, "analytics");