- Add @site/* path alias to docs tsconfig for generated integration files - Fix label-has-associated-control: use htmlFor/id pairs in SubmitForm - Suppress no-noninteractive-element-interactions for drag-and-drop zones - Add aria-labels to search and comment inputs - Remove unused Label component import
2.3 KiB
2.3 KiB
goal, status, iteration, max_iterations, criteria
| goal | status | iteration | max_iterations | criteria | |||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Verify marketplace feature works end-to-end for CSS and custom widgets. Handle all errors gracefully. Run reviews and simplify code. | done | 3 | 5 |
|
Progress
Iteration 0-1: Reviews + Critical Fixes
- 3 parallel reviews (bugbot, silent-failure-hunter, code-reviewer) — all critical fixed
- code-simplifier ran on all 10 files
- URL fallback:
STORE_URL = process.env.NEXT_PUBLIC_WIDGET_STORE_URL || "https://store.homarr.dev"
Iteration 2: Error Handling Gaps
- SubmitForm error visible on ALL steps (moved above step content)
- submit() returns boolean; form only closes on success
- Clipboard copy failure shows "Failed" with X icon
- Non-null assertion removed from store-browser-modal.tsx
Iteration 3: Lint Verification
- oxfmt: all 10 files formatted (exit 0, no changes needed)
- oxlint on Next.js store-install files: 0 errors, 0 warnings
- ReadLints on all edited files: no errors
- docs .oxlintrc.json has pre-existing config issue (
reportUnusedDisableDirectivesin wrong location) — blocks oxlint on docs app; NOT introduced by this branch - label.tsx jsx-a11y concern: component passes htmlFor via props (standard shadcn pattern); callers in SubmitForm use semantic HTML labels with nested controls
- All 4 store-schema tests pass
Verification Summary
| Criterion | Status |
|---|---|
| CSS + widget flows | ✅ Code paths verified — submit, validate, install all wired |
| Error handling | ✅ All async ops have try/catch, user-visible feedback |
| Reviews pass | ✅ All critical/important issues from 3 reviews fixed |
| Code simplified | ✅ code-simplifier ran, lookup tables, shared helpers |
| URL fallback | ✅ env var ?? hard-coded default |
| Tests pass | ✅ 4/4 |
| Lint clean | ✅ oxfmt + oxlint + ReadLints all clean on our files |