ajnart
57ef0af4a2
Production source maps (--enable-source-maps) caused a ~50% memory increase (600MB to 1000MB) in v1.68.0. Node.js loads all .map files into memory when this flag is enabled, and Next.js server chunks generate hundreds of map files. Changes: - Guard productionBrowserSourceMaps and serverSourceMaps behind HOMARR_ENABLE_SOURCE_MAPS env var (default off) - Guard .map copy step and NODE_OPTIONS in Dockerfile behind ENABLE_SOURCE_MAPS build arg (default false) - run.sh checks HOMARR_ENABLE_SOURCE_MAPS before setting --enable-source-maps - Add Docker-based memory regression CI job (<700MB threshold) Closes #6123
86 lines
2.9 KiB
Docker
86 lines
2.9 KiB
Docker
FROM node:24.17.0-alpine AS base
|
|
|
|
FROM base AS builder
|
|
RUN apk add --no-cache libc6-compat
|
|
RUN apk update
|
|
|
|
# Set working directory
|
|
WORKDIR /app
|
|
RUN apk add --no-cache libc6-compat curl bash
|
|
RUN apk update
|
|
COPY . .
|
|
|
|
RUN corepack enable pnpm && pnpm install --recursive --frozen-lockfile
|
|
|
|
# Copy static data as it is not part of the build
|
|
COPY static-data ./static-data
|
|
ARG SKIP_ENV_VALIDATION='true'
|
|
ARG CI='true'
|
|
ARG DISABLE_REDIS_LOGS='true'
|
|
|
|
RUN corepack enable pnpm && pnpm build
|
|
|
|
# Copy server chunk source maps into standalone output when enabled.
|
|
# Off by default to avoid the significant memory overhead of --enable-source-maps in Node.js.
|
|
# See https://github.com/homarr-labs/homarr/issues/6123 and https://github.com/nodejs/node/issues/46140
|
|
ARG ENABLE_SOURCE_MAPS=false
|
|
RUN if [ "$ENABLE_SOURCE_MAPS" = "true" ]; then \
|
|
cd apps/nextjs/.next/server && \
|
|
find . -name '*.map' | while IFS= read -r map; do \
|
|
dest="../standalone/apps/nextjs/.next/server/$map"; \
|
|
mkdir -p "$(dirname "$dest")"; \
|
|
cp "$map" "$dest"; \
|
|
done; \
|
|
fi
|
|
|
|
FROM base AS runner
|
|
WORKDIR /app
|
|
|
|
# gettext is required for envsubst, openssl for generating AUTH_SECRET, su-exec for running application as non-root
|
|
RUN apk add --no-cache redis nginx bash gettext su-exec openssl
|
|
RUN mkdir /appdata
|
|
VOLUME /appdata
|
|
|
|
# Enable homarr cli
|
|
COPY --from=builder /app/packages/cli/cli.cjs /app/apps/cli/cli.cjs
|
|
RUN echo $'#!/bin/bash\ncd /app/apps/cli && node ./cli.cjs "$@"' > /usr/bin/homarr
|
|
RUN chmod +x /usr/bin/homarr
|
|
|
|
# Don't run production as root
|
|
RUN mkdir -p /var/cache/nginx && \
|
|
mkdir -p /var/log/nginx && \
|
|
mkdir -p /var/lib/nginx && \
|
|
touch /run/nginx/nginx.pid && \
|
|
mkdir -p /etc/nginx/templates /etc/nginx/ssl/certs
|
|
|
|
COPY --from=builder /app/apps/nextjs/next.config.ts .
|
|
COPY --from=builder /app/apps/nextjs/package.json .
|
|
|
|
COPY --from=builder /app/node_modules/better-sqlite3/build/Release/better_sqlite3.node /app/build/better_sqlite3.node
|
|
|
|
COPY --from=builder /app/packages/db/migrations ./db/migrations
|
|
|
|
# Automatically leverage output traces to reduce image size
|
|
# https://nextjs.org/docs/advanced-features/output-file-tracing
|
|
COPY --from=builder /app/apps/nextjs/.next/standalone ./
|
|
COPY --from=builder /app/apps/nextjs/.next/static ./apps/nextjs/.next/static
|
|
COPY --from=builder /app/apps/nextjs/public ./apps/nextjs/public
|
|
COPY scripts/run.sh ./run.sh
|
|
COPY --chmod=755 scripts/entrypoint.sh ./entrypoint.sh
|
|
COPY packages/redis/redis.conf /app/redis.conf
|
|
COPY nginx.conf /etc/nginx/templates/nginx.conf
|
|
|
|
|
|
ENV DB_URL='/appdata/db/db.sqlite'
|
|
ENV DB_DIALECT='sqlite'
|
|
ENV DB_DRIVER='better-sqlite3'
|
|
ENV AUTH_PROVIDERS='credentials'
|
|
ENV REDIS_IS_EXTERNAL='false'
|
|
ENV NODE_ENV='production'
|
|
# Pass through the source maps toggle so run.sh can conditionally set NODE_OPTIONS.
|
|
ARG ENABLE_SOURCE_MAPS=false
|
|
ENV HOMARR_ENABLE_SOURCE_MAPS=$ENABLE_SOURCE_MAPS
|
|
|
|
ENTRYPOINT [ "/app/entrypoint.sh" ]
|
|
CMD ["sh", "run.sh"]
|