3.8 KiB
3.8 KiB
Changes — 2026-07-03
PR #5984 Review And Dev Merge Fixes
- Why: Make
feat/widget-storemergeable withdevand address CodeRabbit review feedback before requesting another review. - What: Merged
origin/dev, resolvedapps/docs/package.jsonandpnpm-lock.yaml, and fixed workshop vote state handling, 404-only vote recovery, PocketBase filename URL encoding, required widget$schemavalidation, install-button localization, public author email fallback, placeholder product copy, and workshop safety/submission guidance. - Files:
apps/docs/src/components/store/useStore.ts,apps/docs/src/lib/pocketbase.ts,apps/docs/src/lib/store-schema.ts,apps/docs/src/lib/store-schema.spec.ts,apps/nextjs/src/components/store-install/install-from-store-buttons.tsx,packages/translation/src/lang/en.json,apps/store/pb_migrations/1750000002_marketplace_view.js,apps/docs/docs/management/store/index.mdx,PRODUCT.md,pnpm-lock.yaml,apps/docs/package.json. - Tests:
pnpm lintpassed with warnings,pnpm typecheckpassed,pnpm exec vitest run apps/docs/src/lib/store-schema.spec.tspassed. Fullpnpm testfailed on unrelated timeout/external-dependency tests: Immich icon fetch, Pi-hole container, MySQL migration, and Nextcloud hook. - Docs: Updated workshop management docs with a stronger safety warning and submission guidelines.
- Risks: The commit includes a large required
devmerge, so review should distinguish upstream merge changes from the scoped CodeRabbit fixes.
PR #5984 Additional CodeRabbit Fixes
- Why: Resolve the remaining actionable CodeRabbit comments before requesting Copilot review.
- What: Commented out opt-in example env flags, pinned the PocketBase image, ignored store-local env files, documented PocketBase admin bootstrap vars, enabled GitHub OAuth only when credentials are present, indexed
comments.submission, added reduced-motion handling for submit-step animation, added accessible comment action labels, used created vote records directly on detail pages, tracked copy-failure timers for cleanup, prevented screenshot carousel controls from navigating card links, and normalized theuseStoreutils import alias. - Files:
.env.example,apps/store/docker-compose.yml,apps/store/.gitignore,apps/store/README.md,apps/store/pb_migrations/1750000000_init_store.js,apps/docs/src/css/custom.css,apps/docs/src/components/store/DetailPage.tsx,apps/docs/src/components/store/StoreApp.tsx,apps/docs/src/components/store/useStore.ts. - Tests:
pnpm --filter @homarr/docs typecheck,pnpm --filter @homarr/docs lint,pnpm --filter nextjs typecheck, andpnpm exec vitest run apps/docs/src/lib/store-schema.spec.tspassed; docs lint still reports pre-existing warnings outside this fix set. - Docs: Updated
apps/store/README.mdwith admin bootstrap variables. - Risks: PocketBase image pin assumes
ghcr.io/muchobien/pocketbase:0.26.2remains the intended runtime version for this new store service.
PR #5984 Final Review Stability Fix
- Why: Address CodeRabbit's remaining outside-diff stability comments before the final push.
- What: Updated
useStoreto await PocketBase auth refresh before loading workshop data and to returnnullfromrequireUserIdon auth failures, allowing vote lock cleanup to run. - Files:
apps/docs/src/components/store/useStore.ts,.opencode/changelog/2026-07-03.md. - Tests:
pnpm --filter @homarr/docs typecheck,pnpm --filter @homarr/docs lint, andpnpm exec vitest run apps/docs/src/lib/store-schema.spec.tspassed; docs lint still reports pre-existing warnings outside this fix. - Docs: Changelog updated only.
- Risks: Low; the change preserves existing auth refresh behavior but sequences initial loading after auth state is known.