fix: complete widget review cleanup

packages/request-handler/src/timetable.spec.ts

@@ -65,13 +65,30 @@ describe("timetable response bounds", () => {
   });
 
   it("pins the vetted address into a direct connection without changing the request hostname", async () => {
-    mockFetch.mockResolvedValue(
-      new Response(JSON.stringify([{ id: "station", label: "Station", iconclass: "train" }])),
-    );
     const pinnedAddresses = [
       { address: "93.184.216.34", family: 4 as const },
       { address: "2606:2800:220:1:248:1893:25c8:1946", family: 6 as const },
     ];
+    mockFetch.mockImplementation(async () => {
+      const pinnedLookup = mockCreateCertificateAgent.mock.calls[0]?.[0]?.lookup;
+      expect(pinnedLookup).toBeTypeOf("function");
+      if (!pinnedLookup) throw new Error("Expected a pinned lookup function");
+
+      const lookupCallback = vi.fn();
+      pinnedLookup("timetable.example.com", { all: true }, lookupCallback);
+      expect(lookupCallback).toHaveBeenCalledWith(null, pinnedAddresses);
+
+      const repeatedLookupCallback = vi.fn();
+      pinnedLookup("timetable.example.com", { all: true }, repeatedLookupCallback);
+      expect(repeatedLookupCallback).toHaveBeenCalledWith(null, pinnedAddresses);
+      expect(mockCloseDispatcher).not.toHaveBeenCalled();
+
+      const unexpectedHostCallback = vi.fn();
+      pinnedLookup("different.example.com", { all: true }, unexpectedHostCallback);
+      expect(unexpectedHostCallback.mock.calls[0]?.[0]).toMatchObject({ code: "ENOTFOUND" });
+
+      return new Response(JSON.stringify([{ id: "station", label: "Station", iconclass: "train" }]));
+    });
 
     await timetableSearchStationsRequestHandler
       .handler({
@@ -98,21 +115,44 @@ describe("timetable response bounds", () => {
       expect.objectContaining({ dispatcher: mockDispatcher, redirect: "error" }),
     );
 
-    const pinnedLookup = mockCreateCertificateAgent.mock.calls[0]?.[0]?.lookup;
-    expect(pinnedLookup).toBeTypeOf("function");
-    if (!pinnedLookup) throw new Error("Expected a pinned lookup function");
+    expect(mockCloseDispatcher).toHaveBeenCalledOnce();
+  });
 
-    const lookupCallback = vi.fn();
-    pinnedLookup("timetable.example.com", { all: true }, lookupCallback);
-    expect(lookupCallback).toHaveBeenCalledWith(null, pinnedAddresses);
+  it("pins timetable requests and closes their direct dispatcher", async () => {
+    mockFetch.mockResolvedValue(
+      new Response(
+        JSON.stringify({
+          connections: [
+            {
+              time: "2026-01-01T00:00:00Z",
+              line: "1",
+              color: "ffffff",
+              terminal: { name: "Stop" },
+              dep_delay: "0",
+            },
+          ],
+        }),
+      ),
+    );
+    const pinnedAddresses = [{ address: "93.184.216.34", family: 4 as const }];
 
-    const repeatedLookupCallback = vi.fn();
-    pinnedLookup("timetable.example.com", { all: true }, repeatedLookupCallback);
-    expect(repeatedLookupCallback).toHaveBeenCalledWith(null, pinnedAddresses);
+    await timetableGetTimetableRequestHandler
+      .handler({
+        baseUrl: "https://timetable.example.com",
+        stationId: "pinned-departures",
+        limit: 1,
+        pinnedAddresses,
+      })
+      .getDataAsync();
 
-    const unexpectedHostCallback = vi.fn();
-    pinnedLookup("different.example.com", { all: true }, unexpectedHostCallback);
-    expect(unexpectedHostCallback.mock.calls[0]?.[0]).toMatchObject({ code: "ENOTFOUND" });
+    expect(mockCreateCertificateAgent).toHaveBeenCalledWith(
+      { lookup: expect.any(Function) },
+      expect.objectContaining({ noProxy: "*" }),
+    );
+    expect(mockFetch).toHaveBeenCalledWith(
+      expect.any(String),
+      expect.objectContaining({ dispatcher: mockDispatcher, redirect: "error" }),
+    );
     expect(mockCloseDispatcher).toHaveBeenCalledOnce();
   });