chore: reconcile mobile layer after stack rebase

apps/nextjs/src/components/board/items/actions/empty-position.ts

@@ -7,7 +7,7 @@ export const getFirstEmptyPosition = (
   size: { width: number; height: number } = { width: 1, height: 1 },
 ) => {
   for (let yOffset = 0; yOffset < rowCount + 1 - size.height; yOffset++) {
-    for (let xOffset = 0; xOffset < columnCount; xOffset++) {
+    for (let xOffset = 0; xOffset < columnCount + 1 - size.width; xOffset++) {
       const isOccupied = elements.some(
         (element) =>
           element.yOffset < yOffset + size.height &&

apps/nextjs/src/components/board/layout/test/board-lanes.spec.ts

@@ -16,6 +16,7 @@ describe("board lanes", () => {
       leftGutterColumnCount: 2,
       rightGutterColumnCount: 3,
       breakpoint: 0,
+      role: "base",
     } satisfies Board["layouts"][number];
 
     expect(getBoardLaneColumnCount(layout, "left")).toBe(2);
@@ -31,6 +32,7 @@ describe("board lanes", () => {
       leftGutterColumnCount: 3,
       rightGutterColumnCount: 3,
       breakpoint: 0,
+      role: "base",
     } satisfies Board["layouts"][number];
 
     expect(getBoardLaneColumnCount(layout, "left")).toBe(3);
@@ -120,6 +122,7 @@ describe("board lanes", () => {
         leftGutterColumnCount: 1,
         rightGutterColumnCount: 0,
         breakpoint: 0,
+        role: "base",
       },
     ];
 

apps/nextjs/src/components/board/sections/gridstack/gridstack.spec.ts

@@ -1,11 +0,0 @@
-import { describe, expect, test } from "vitest";
-
-import { filterRecursiveInnerSections } from "./gridstack";
-
-describe("filterRecursiveInnerSections", () => {
-  test("removes sections that would recursively render an ancestor", () => {
-    const innerSections = [{ id: "safe" }, { id: "parent" }, { id: "root" }];
-
-    expect(filterRecursiveInnerSections(innerSections, new Set(["root", "parent"]))).toEqual([{ id: "safe" }]);
-  });
-});

apps/nextjs/src/components/board/sections/section-actions.spec.ts

@@ -1,18 +1,18 @@
 import { describe, expect, test } from "vitest";
 
 import { BoardMockBuilder } from "~/components/board/items/actions/test/mocks/board-mock";
-import { DynamicSectionMockBuilder } from "~/components/board/items/actions/test/mocks/dynamic-section-mock";
+import { ContainerSectionMockBuilder } from "~/components/board/items/actions/test/mocks/container-section-mock";
 import { EmptySectionMockBuilder } from "~/components/board/items/actions/test/mocks/empty-section-mock";
 import { wouldCreateSectionCycle } from "./section-actions";
 
 describe("wouldCreateSectionCycle", () => {
-  test("rejects moving a dynamic section into itself or one of its descendants", () => {
+  test("rejects moving a container into itself or one of its descendants", () => {
     const layoutId = "layout";
     const rootSection = new EmptySectionMockBuilder({ id: "root" }).build();
-    const parentSection = new DynamicSectionMockBuilder({ id: "parent" })
+    const parentSection = new ContainerSectionMockBuilder({ id: "parent" })
       .addLayout({ layoutId, parentSectionId: rootSection.id })
       .build();
-    const childSection = new DynamicSectionMockBuilder({ id: "child" })
+    const childSection = new ContainerSectionMockBuilder({ id: "child" })
       .addLayout({ layoutId, parentSectionId: parentSection.id })
       .build();
     const board = new BoardMockBuilder().addSections([rootSection, parentSection, childSection]).build();

apps/nextjs/src/components/board/sections/section-actions.tsx

@@ -101,7 +101,7 @@ export const wouldCreateSectionCycle = (
     visitedSectionIds.add(currentSectionId);
 
     const currentSection = board.sections.find((section) => section.id === currentSectionId);
-    if (currentSection?.kind !== "dynamic") return false;
+    if (currentSection?.kind !== "container") return false;
 
     currentSectionId = currentSection.layouts.find((layout) => layout.layoutId === layoutId)?.parentSectionId ?? null;
   }

apps/nextjs/src/components/user-avatar-menu.tsx

@@ -21,17 +21,9 @@ interface UserAvatarMenuProps {
   children: ReactNode;
   availableUpdates?: RouterOutputs["updateChecker"]["getAvailableUpdates"];
   isDockerEnabled?: boolean;
-  opened: boolean;
-  onOpenChange: (opened: boolean) => void;
 }
 
-export const UserAvatarMenu = ({
-  children,
-  availableUpdates,
-  isDockerEnabled,
-  opened,
-  onOpenChange,
-}: UserAvatarMenuProps) => {
+export const UserAvatarMenu = ({ children, availableUpdates, isDockerEnabled }: UserAvatarMenuProps) => {
   const t = useScopedI18n("common.userAvatar.menu");
   const session = useSession();
 
@@ -48,7 +40,7 @@ export const UserAvatarMenu = ({
 
   return (
     // We use keepMounted so we can add event listeners to prevent navigating away without saving the board
-    <Menu width={300} withinPortal keepMounted opened={opened} onChange={onOpenChange}>
+    <Menu width={300} withinPortal keepMounted>
       <Menu.Dropdown>
         <AvailableUpdatesMenuItem availableUpdates={availableUpdates} />
         <Menu.Item component={Link} href="/boards" leftSection={<IconHome size="1rem" />}>