fix: address utility widget review

This commit is contained in:
ajnart committed 2026-08-20 15:33:28 +02:00
1 parent 52d96505a3
commit e3475d3efe
17 files changed
+138 -73

No files matched your search

@@ -75,6 +75,7 @@ describe("weather request handler", () => {
it("requests bounded useful forecasts and normalizes location times", async () => {
const response = makeWeatherResponse();
response.hourly.temperature_2m = [null];
Reflect.deleteProperty(response.hourly, "wind_gusts_10m");
response.daily.sunrise[1] = null;
mockFetch.mockResolvedValue(new Response(JSON.stringify(response)));
@@ -87,6 +88,7 @@ describe("weather request handler", () => {
expect(first.data.daily[0]?.date).toBe("2026-07-01");
expect(first.data.hourly[0]?.temperature).toBeNull();
expect(first.data.hourly[1]?.temperature).toBeNull();
expect(first.data.hourly[0]?.windGusts).toBeNull();
expect(first.data.daily[0]?.sunriseAt).toBeNull();
expect(first.data.daily[1]?.sunriseAt).toBe("2026-07-02T03:00:00.000Z");
expect(second.data).toStrictEqual(first.data);
+4 -3
View File
@@ -144,7 +144,8 @@ export const weatherRequestHandler = createWidgetRequestHandler({
requestAsync: requestWeatherAsync,
});
const nullableNumberArray = z.array(z.number().nullable());
const nullableNumberArray = z.array(z.number().nullable()).default([]);
const nullableStringArray = z.array(z.string().nullable()).default([]);
const atLocationOutput = z.object({
timezone: z.string().min(1),
@@ -184,8 +185,8 @@ const atLocationOutput = z.object({
wind_speed_10m_max: nullableNumberArray,
wind_gusts_10m_max: nullableNumberArray,
uv_index_max: nullableNumberArray,
sunrise: z.array(z.string().nullable()),
sunset: z.array(z.string().nullable()),
sunrise: nullableStringArray,
sunset: nullableStringArray,
daylight_duration: nullableNumberArray,
}),
});