fix(custom-widgets): address v2 merge review (#6446)
This commit is contained in:
1 parent
6aceb2fd1f
commit
df967751f6
123 files changed
+8632
-1477
No files matched your search
@@ -1,11 +1,19 @@
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { CustomWidgetRequestLimiter } from "../server";
|
||||
import {
|
||||
CUSTOM_WIDGET_REQUEST_CONCURRENCY_TTL_MS,
|
||||
CustomWidgetRequestLimiter,
|
||||
MAX_REQUEST_DURATION_MS,
|
||||
} from "../server";
|
||||
import type { RequestLimitStore } from "../server";
|
||||
|
||||
const input = { category: "action", userId: "user", itemId: "item", definitionId: "definition" } as const;
|
||||
|
||||
describe("custom widget request limits", () => {
|
||||
it("keeps owned concurrency leases beyond the total request deadline", () => {
|
||||
expect(CUSTOM_WIDGET_REQUEST_CONCURRENCY_TTL_MS).toBeGreaterThan(MAX_REQUEST_DURATION_MS);
|
||||
});
|
||||
|
||||
it("enforces local per-user/item concurrency and releases capacity", async () => {
|
||||
const limiter = new CustomWidgetRequestLimiter();
|
||||
const releases = await Promise.all(Array.from({ length: 4 }, () => limiter.acquire(input)));
|
||||
@@ -39,4 +47,31 @@ describe("custom widget request limits", () => {
|
||||
});
|
||||
expect(store.releaseConcurrency).toHaveBeenCalledOnce();
|
||||
});
|
||||
|
||||
it("releases only the concurrency lease owned by the request", async () => {
|
||||
const owners = new Set<string>();
|
||||
const store: RequestLimitStore = {
|
||||
incrementRate: vi.fn(async () => ({ count: 1, retryAfterMs: 60_000 })),
|
||||
acquireConcurrency: vi.fn(async (_key, ownerId) => {
|
||||
owners.add(ownerId);
|
||||
return true;
|
||||
}),
|
||||
releaseConcurrency: vi.fn(async (_key, ownerId) => {
|
||||
owners.delete(ownerId);
|
||||
}),
|
||||
};
|
||||
const releaseFirst = await new CustomWidgetRequestLimiter({ store }).acquire(input);
|
||||
const firstOwner = [...owners][0];
|
||||
expect(store.acquireConcurrency).toHaveBeenCalledWith(
|
||||
expect.any(String),
|
||||
firstOwner,
|
||||
expect.any(Number),
|
||||
CUSTOM_WIDGET_REQUEST_CONCURRENCY_TTL_MS,
|
||||
);
|
||||
await releaseFirst();
|
||||
|
||||
expect(firstOwner).toBeTypeOf("string");
|
||||
expect(store.releaseConcurrency).toHaveBeenCalledWith(expect.any(String), firstOwner);
|
||||
expect(owners).not.toContain(firstOwner);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user