fix(custom-widgets): address review and CI
This commit is contained in:
1 parent
2153069a2f
commit
da57a937ed
10 files changed
+49
-46
No files matched your search
@@ -29,6 +29,7 @@ interface DirectCodeMirrorProps {
|
||||
placeholder?: string;
|
||||
height: string;
|
||||
theme: "light" | "dark";
|
||||
invalid: boolean;
|
||||
readOnly: boolean;
|
||||
diagnosticMessage(diagnostic: EditorDiagnostic): string;
|
||||
onChange(value: string): void;
|
||||
@@ -124,9 +125,10 @@ export default function DirectCodeMirror(props: DirectCodeMirrorProps) {
|
||||
tabindex: "0",
|
||||
"aria-label": props.label,
|
||||
"aria-labelledby": props.labelledBy,
|
||||
"aria-invalid": props.invalid.toString(),
|
||||
}),
|
||||
);
|
||||
}, [compartments.accessibility, instanceId, props.id, props.label, props.labelledBy]);
|
||||
}, [compartments.accessibility, instanceId, props.id, props.invalid, props.label, props.labelledBy]);
|
||||
useEffect(() => {
|
||||
reconfigure(instanceId, compartments.editability, createEditabilityExtension(props.readOnly));
|
||||
}, [compartments.editability, instanceId, props.readOnly]);
|
||||
@@ -166,6 +168,7 @@ function createExtensions(instanceId: string, props: DirectCodeMirrorProps, comp
|
||||
tabindex: "0",
|
||||
"aria-label": props.label,
|
||||
"aria-labelledby": props.labelledBy,
|
||||
"aria-invalid": props.invalid.toString(),
|
||||
}),
|
||||
),
|
||||
compartments.editability.of(createEditabilityExtension(props.readOnly)),
|
||||
|
||||
Reference in new issue
Block a user