fix(workshop): use PocketBase name

apps/workshop/tests/oauth-sync.integration.mjs

@@ -24,7 +24,7 @@ if (!users.oauth2?.enabled || github?.clientId !== expectedClientId) {
   throw new Error(`GitHub OAuth was not synchronized for ${expectedClientId}`);
 }
 if (
-  users.oauth2?.mappedFields?.username !== "githubUsername" ||
+  users.oauth2?.mappedFields?.username !== "name" ||
   users.oauth2?.mappedFields?.id ||
   users.oauth2?.mappedFields?.name ||
   users.oauth2?.mappedFields?.avatarURL

apps/workshop/tests/workshop-contracts.mjs

@@ -15,7 +15,7 @@ if (!hook.includes("require(`${__hooks}/workshop-utils.js`)")) {
 if (!hook.includes("onBootstrap") || !hook.includes("users.oauth2.providers = configured")) {
   throw new Error("Workshop OAuth settings must be synchronized at every bootstrap");
 }
-if (!hook.includes('username: "githubUsername"') || hook.includes("onRecordAuthWithOAuth2Request")) {
+if (!hook.includes('username: "name"') || hook.includes("onRecordAuthWithOAuth2Request")) {
   throw new Error("Workshop identity must use PocketBase's direct GitHub username mapping");
 }
 if (hook.includes("validateAndNormalizeSubmission")) {
@@ -41,7 +41,7 @@ if (hook.includes('findAllRecords("users")') || !hook.includes('findRecordsByFil
 }
 
 const migration = await read("apps/workshop/pb_migrations/1784240000_workshop_widgets.js");
-for (const removedField of ["displayName", "avatarUrl", "githubProfileUrl"]) {
+for (const removedField of ["displayName", "avatarUrl", "githubProfileUrl", "githubUsername"]) {
   if (migration.includes(removedField)) throw new Error(`Redundant Workshop user field remains: ${removedField}`);
 }
 for (const required of [

apps/workshop/tests/workshop.integration.mjs

@@ -46,7 +46,7 @@ await request("/api/collections/users", {
   body: JSON.stringify({ ...usersCollection, passwordAuth: { enabled: true, identityFields: ["email"] } }),
 });
 
-const createUser = async (email, githubUsername, password, extra = {}) =>
+const createUser = async (email, name, password, extra = {}) =>
   request("/api/collections/users/records", {
     method: "POST",
     headers: rootHeaders,
@@ -56,7 +56,7 @@ const createUser = async (email, githubUsername, password, extra = {}) =>
       verified: true,
       password,
       passwordConfirm: password,
-      githubUsername,
+      name,
       ...extra,
     }),
   });
@@ -79,13 +79,13 @@ await expectStatus(
 );
 await expectStatus(
   `/api/collections/users/records/${author.id}`,
-  { method: "PATCH", headers: authorSession.headers, body: JSON.stringify({ githubUsername: "homarr-labs" }) },
+  { method: "PATCH", headers: authorSession.headers, body: JSON.stringify({ name: "homarr-labs" }) },
   404,
 );
 const unchangedAuthor = await request(`/api/collections/users/records/${author.id}`, {
   headers: authorSession.headers,
 });
-if (unchangedAuthor.githubUsername !== "widget-author") {
+if (unchangedAuthor.name !== "widget-author") {
   throw new Error("Workshop users can forge OAuth provider identity fields");
 }
 
@@ -221,7 +221,7 @@ if (
   listing.score !== 2 ||
   listing.upvotes !== 2 ||
   listing.downvotes !== 0 ||
-  listing.authorGithubUsername !== "widget-author" ||
+  listing.authorName !== "widget-author" ||
   listing.widgetSchema !== widget.$schema
 ) {
   throw new Error("Workshop listing data is incorrect");
@@ -232,7 +232,7 @@ const comment = await request("/api/collections/comments/records?expand=author",
   headers: visitorSession.headers,
   body: JSON.stringify({ submission: submission.id, author: visitor.id, content: "Useful widget" }),
 });
-if (comment.author !== visitor.id || comment.expand.author.githubUsername !== "widget-visitor") {
+if (comment.author !== visitor.id || comment.expand.author.name !== "widget-visitor") {
   throw new Error("Comment author expansion is incorrect");
 }
 await expectStatus(