fix(cli): resolve PR review feedback and improve command execution

This commit is contained in:
Thomas Camlong committed 2026-08-21 17:01:29 +02:00
1 parent 7c4c1ffbe7
commit c8df2fbe5f
14 files changed
+149 -42

No files matched your search

+42 -4
View File
@@ -19,6 +19,8 @@ func (m Model) handleKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) {
return m.handleFilterKey(msg)
case modeConfirm:
return m.handleConfirmKey(msg)
case modeImageSelect:
return m.handleImageSelectKey(msg)
case modeManage:
return m.handleManageKey(msg)
case modeHelp:
@@ -30,6 +32,42 @@ func (m Model) handleKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) {
}
}
func (m Model) handleImageSelectKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) {
switch {
case key.Matches(msg, m.keys.Cancel):
m.mode = modeNormal
m.imageSelection = imageSelection{}
m.status, m.statusLevel = "launch canceled", levelInfo
m.relayout()
return m, nil
case key.Matches(msg, m.keys.Up), key.Matches(msg, m.keys.Down):
if m.imageSelection.choice == imageChoiceLocal {
m.imageSelection.choice = imageChoiceRemote
} else {
m.imageSelection.choice = imageChoiceLocal
}
return m, nil
case key.Matches(msg, m.keys.Enter):
selection := m.imageSelection
row, found := m.selectedDev()
m.mode = modeNormal
m.imageSelection = imageSelection{}
if !found || row.key() != selection.rowKey {
m.status, m.statusLevel = "image selection expired; choose a row again", levelWarn
m.relayout()
return m, nil
}
m.relayout()
if selection.choice == imageChoiceRemote {
return m.deployRemotePR(row)
}
return m.startLocalPR(row)
}
return m, nil
}
func (m Model) handleNormalKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) {
switch {
case key.Matches(msg, m.keys.Quit):
@@ -245,8 +283,8 @@ func (m Model) handleFilterKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) {
m.filter.Reset()
m.filter.Blur()
m.relayout()
m.refreshSidebar()
return m, nil
cmd := m.refreshSidebar()
return m, cmd
case tea.KeyEnter:
m.mode = modeNormal
m.filter.Blur()
@@ -256,8 +294,8 @@ func (m Model) handleFilterKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) {
var command tea.Cmd
m.filter, command = m.filter.Update(msg)
m.applyFilter()
m.refreshSidebar()
return m, command
cmd := m.refreshSidebar()
return m, tea.Batch(command, cmd)
}
func (m Model) handleOverlayKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) {