From bbb04b084f387e444691f77e8b7b1518b55c83f6 Mon Sep 17 00:00:00 2001 From: Thomas Camlong Date: Thu, 28 May 2026 12:16:14 +0200 Subject: [PATCH] fix(definitions): use HTTPS for subdomain URL template Subdomain-based URLs (e.g. sonarr.example.com) are typically served behind a reverse proxy with TLS. Update the template to generate https:// URLs. Host:port mode remains http:// for local access. --- packages/definitions/src/integration-url-template.ts | 2 +- .../definitions/src/test/integration-url-template.spec.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/definitions/src/integration-url-template.ts b/packages/definitions/src/integration-url-template.ts index 20aca11b3..f47387414 100644 --- a/packages/definitions/src/integration-url-template.ts +++ b/packages/definitions/src/integration-url-template.ts @@ -18,7 +18,7 @@ export const buildIntegrationUrl = ( const slug = getSlugForKind(kind); const modeBuilders: Record string> = { - subdomain: () => `http://${slug}.${host}`, + subdomain: () => `https://${slug}.${host}`, hostPort: () => { const port = dockerPort ?? getIntegrationDefaultPort(kind); return port ? `http://${host}:${port}` : `http://${host}`; diff --git a/packages/definitions/src/test/integration-url-template.spec.ts b/packages/definitions/src/test/integration-url-template.spec.ts index 4fa3c8cc0..6ef2b5f2d 100644 --- a/packages/definitions/src/test/integration-url-template.spec.ts +++ b/packages/definitions/src/test/integration-url-template.spec.ts @@ -5,7 +5,7 @@ import { buildIntegrationUrl } from "../integration-url-template"; describe("buildIntegrationUrl", () => { it("builds subdomain URL", () => { - expect(buildIntegrationUrl("sonarr", "homelab.local", "subdomain")).toBe("http://sonarr.homelab.local"); + expect(buildIntegrationUrl("sonarr", "homelab.local", "subdomain")).toBe("https://sonarr.homelab.local"); }); it("builds hostPort URL with default port", () => { @@ -21,7 +21,7 @@ describe("buildIntegrationUrl", () => { }); it("strips trailing slashes from host", () => { - expect(buildIntegrationUrl("sonarr", "homelab.local/", "subdomain")).toBe("http://sonarr.homelab.local"); + expect(buildIntegrationUrl("sonarr", "homelab.local/", "subdomain")).toBe("https://sonarr.homelab.local"); }); it("returns empty string for empty host", () => { @@ -29,7 +29,7 @@ describe("buildIntegrationUrl", () => { }); it("uses pi-hole slug for subdomain mode", () => { - expect(buildIntegrationUrl("piHole", "example.com", "subdomain")).toBe("http://pi-hole.example.com"); + expect(buildIntegrationUrl("piHole", "example.com", "subdomain")).toBe("https://pi-hole.example.com"); }); it("reads default ports from integration definitions", () => {