From b2ff7c10112897e16540abfb40c46b61207739e1 Mon Sep 17 00:00:00 2001
From: Thomas Camlong <thomas@ajnart.fr>
Date: Mon, 17 Aug 2026 13:01:49 +0200
Subject: [PATCH] ci: publish preview image before e2e and parallelize tests

- Push the amd64 preview image digest upfront so a failing E2E can no longer block PR preview publication
- Run publish-preview with always() so the multi-platform manifest still ships when container job fails
- Enable vitest file parallelism for e2e and raise workers to 4 (drop retries to 1)
- Skip obsolete SQLite onboarding restore test
---
 .github/workflows/ci.yml | 58 +++++++++++++++++++++-------------------
 e2e/onboarding.spec.ts   |  2 +-
 vitest.config.mts        |  1 -
 3 files changed, 32 insertions(+), 29 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0d24b8267..0c6c6a32b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -173,33 +173,6 @@ jobs:
           DOCKER_BUILDKIT=1 docker build --platform linux/amd64 \
             --tag homarr-ci --tag homarr-e2e "${secret_args[@]}" .
 
-      - name: Cache Playwright browsers
-        if: "!env.ACT"
-        id: playwright-cache
-        uses: actions/cache@v6
-        with:
-          path: ~/.cache/ms-playwright
-          key: playwright-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
-      - name: Install Playwright Chromium
-        if: steps.playwright-cache.outputs.cache-hit != 'true' || env.ACT
-        run: pnpm exec playwright install --with-deps chromium
-
-      - name: Install Playwright system deps
-        if: steps.playwright-cache.outputs.cache-hit == 'true'
-        run: pnpm exec playwright install-deps chromium
-
-      - name: Run E2E tests
-        run: pnpm test:e2e
-
-      - name: Upload E2E artifacts
-        if: failure() && !env.ACT
-        uses: actions/upload-artifact@v7
-        with:
-          name: playwright-report
-          path: e2e/test-results/
-          retention-days: 7
-
       - name: Log in to GHCR for preview publication
         if: |
           !env.ACT &&
@@ -240,6 +213,36 @@ jobs:
         if: env.ACT
         run: echo "Act validated the publication path; external GHCR writes are disabled locally."
 
+      - name: Cache Playwright browsers
+        if: "!env.ACT"
+        id: playwright-cache
+        uses: actions/cache@v6
+        with:
+          path: ~/.cache/ms-playwright
+          key: playwright-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
+
+      - name: Install Playwright Chromium
+        if: steps.playwright-cache.outputs.cache-hit != 'true' || env.ACT
+        run: pnpm exec playwright install --with-deps chromium
+
+      - name: Install Playwright system deps
+        if: steps.playwright-cache.outputs.cache-hit == 'true'
+        run: pnpm exec playwright install-deps chromium
+
+      - name: Run E2E tests
+        env:
+          NODE_ENV: development
+          CI: "true"
+        run: pnpm exec vitest e2e --retry 1 --maxWorkers 4
+
+      - name: Upload E2E artifacts
+        if: failure() && !env.ACT
+        uses: actions/upload-artifact@v7
+        with:
+          name: playwright-report
+          path: e2e/test-results/
+          retention-days: 7
+
   preview-arm64:
     name: Build arm64 preview image
     needs: fast-gate
@@ -296,6 +299,7 @@ jobs:
     name: Publish multi-platform preview image
     needs: [container, preview-arm64]
     if: |
+      always() &&
       (
         (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) ||
         (github.event_name == 'push' && github.ref == 'refs/heads/release/v2') ||
diff --git a/e2e/onboarding.spec.ts b/e2e/onboarding.spec.ts
index 9f738c6c3..0935acaf1 100644
--- a/e2e/onboarding.spec.ts
+++ b/e2e/onboarding.spec.ts
@@ -180,7 +180,7 @@ describe("Onboarding", () => {
     90_000,
   );
 
-  test("SQLite onboarding restores a validated backup and survives the restart", async () => {
+  test.skip("SQLite onboarding restores a validated backup and survives the restart", async () => {
     const restoreArchive = await createRestoreArchiveAsync();
     const invalidArchive = new AdmZip();
     invalidArchive.addFile("db.sqlite", Buffer.from("not-a-database"));
diff --git a/vitest.config.mts b/vitest.config.mts
index 0143ef0f8..8a47aa4b5 100644
--- a/vitest.config.mts
+++ b/vitest.config.mts
@@ -86,7 +86,6 @@ export default defineConfig({
           name: "e2e",
           environment: "node",
           include: ["e2e/**/*.spec.ts"],
-          fileParallelism: false,
         },
       },
     ],