fix v2 hardening review findings

e2e/shared/actions/onboarding-actions.ts

@@ -32,7 +32,7 @@ export class OnboardingActions {
   }
 
   public async processUserStepAsync(input: { username: string; password: string; confirmPassword: string }) {
-    await this.page.waitForSelector("text=administrator user");
+    await this.page.getByLabel("Username").waitFor({ state: "visible" });
 
     await this.page.getByLabel("Username").fill(input.username);
     await this.page.getByLabel("Password", { exact: true }).fill(input.password);

e2e/shared/mock-api-server.ts

@@ -10,6 +10,19 @@ export interface MockApiServer {
   close: () => Promise<void>;
 }
 
+export async function exposeHostPortToContainersAsync(port: number): Promise<string> {
+  await TestContainers.exposeHostPorts(port);
+  const client = await getContainerRuntimeClient();
+  const forwarder = (await client.container.list()).find(
+    (container) => container.State === "running" && container.Labels[TESTCONTAINERS_SSHD_LABEL] === "true",
+  );
+  const forwarderAddress = forwarder
+    ? Object.values(forwarder.NetworkSettings.Networks).find((network) => network.IPAddress)?.IPAddress
+    : undefined;
+  if (!forwarderAddress) throw new Error("Failed to locate the Testcontainers host-port forwarder");
+  return `http://${forwarderAddress}:${port}`;
+}
+
 export async function startMockApiServerAsync(responseBody: unknown): Promise<MockApiServer> {
   const body = JSON.stringify(responseBody);
   const server: Server = await new Promise((resolve) => {
@@ -26,18 +39,8 @@ export async function startMockApiServerAsync(responseBody: unknown): Promise<Mo
   }
 
   try {
-    await TestContainers.exposeHostPorts(address.port);
-    const client = await getContainerRuntimeClient();
-    const forwarder = (await client.container.list()).find(
-      (container) => container.State === "running" && container.Labels[TESTCONTAINERS_SSHD_LABEL] === "true",
-    );
-    const forwarderAddress = forwarder
-      ? Object.values(forwarder.NetworkSettings.Networks).find((network) => network.IPAddress)?.IPAddress
-      : undefined;
-    if (!forwarderAddress) throw new Error("Failed to locate the Testcontainers host-port forwarder");
-
     return {
-      url: `http://${forwarderAddress}:${address.port}`,
+      url: await exposeHostPortToContainersAsync(address.port),
       close: () =>
         new Promise((resolve, reject) => {
           server.close((error) => (error ? reject(error) : resolve()));