fix: address PR review feedback

- Show error notification on setup failure instead of silent reset
- Fix toggleKind stale closure by using prop array directly
- Remove duplicate translations from en-gb.json (falls back to en.json)
- Align seed board columnCount to 12 (codebase default)
- Extract shared placeAllWidgetsAsync helper to @homarr/db/queries
- Remove redundant onboardingFormSchema; reuse formSchema for both paths
- Fix lint errors (optional chain, unused imports, unnecessary conditions)

packages/definitions/src/docker-integration-match.ts

@@ -3,8 +3,7 @@ import { objectKeys } from "@homarr/common";
 import { integrationDefs } from "./integration";
 import type { IntegrationKind } from "./integration";
 
-export const extractContainerImageName = (image: string): string =>
-  image.split("/").at(-1)?.split(":").at(0) ?? "";
+export const extractContainerImageName = (image: string): string => image.split("/").at(-1)?.split(":").at(0) ?? "";
 
 const extractIconSlug = (iconUrl: string): string => {
   const filename = iconUrl.split("/").pop() ?? "";

packages/definitions/src/integration-url-template.ts

@@ -4,8 +4,7 @@ import { getIntegrationDefaultPort } from "./integration";
 
 export type UrlTemplateMode = "hostPort" | "subdomain";
 
-const getSlugForKind = (kind: IntegrationKind): string =>
-  integrationIconSlugs[kind] ?? kind.toLowerCase();
+const getSlugForKind = (kind: IntegrationKind): string => integrationIconSlugs[kind];
 
 export const buildIntegrationUrl = (
   kind: IntegrationKind,

packages/definitions/src/integration.ts

@@ -473,7 +473,7 @@ export const getIntegrationDefaultPort = (kind: IntegrationKind): number | undef
 
 export const getIntegrationApiKeyUrl = (integrationUrl: string, kind: IntegrationKind): string | null => {
   const definition = integrationDefs[kind];
-  if (!("apiKeySettingsPath" in definition) || !definition.apiKeySettingsPath) return null;
+  if (!("apiKeySettingsPath" in definition)) return null;
   const base = integrationUrl.replace(/\/+$/, "");
   if (!base) return null;
   return `${base}${definition.apiKeySettingsPath}`;

packages/definitions/src/test/api-key-url.spec.ts

@@ -24,8 +24,6 @@ describe("getIntegrationApiKeyUrl", () => {
   });
 
   it("strips trailing slash from base URL", () => {
-    expect(getIntegrationApiKeyUrl("http://sonarr.local/", "sonarr")).toBe(
-      "http://sonarr.local/settings/general",
-    );
+    expect(getIntegrationApiKeyUrl("http://sonarr.local/", "sonarr")).toBe("http://sonarr.local/settings/general");
   });
 });