fix: use typed Map for create-permission parents

The 'in' operator guard did not narrow the GroupPermissionKey union for
indexing, failing the CI typecheck (TS7053). A typed Map with .get()
needs no narrowing and preserves the bundling behavior.
This commit is contained in:
Thomas Camlong committed 2026-08-18 11:05:12 +02:00
1 parent 930d9fc489
commit 8caf00da79
1 file changed
+8 -8
+8 -8
View File
@@ -23,12 +23,12 @@ import {
import { createTRPCRouter, onboardingProcedure, permissionRequiredProcedure, protectedProcedure } from "../trpc"; import { createTRPCRouter, onboardingProcedure, permissionRequiredProcedure, protectedProcedure } from "../trpc";
const createPermissionParents = { const createPermissionParents = new Map<GroupPermissionKey, GroupPermissionKey>([
"app-create": "app-modify-all", ["app-create", "app-modify-all"],
"integration-create": "integration-full-all", ["integration-create", "integration-full-all"],
"board-create": "board-full-all", ["board-create", "board-full-all"],
"search-engine-create": "search-engine-modify-all", ["search-engine-create", "search-engine-modify-all"],
} satisfies Partial<Record<GroupPermissionKey, GroupPermissionKey>>; ]);
export const groupRouter = createTRPCRouter({ export const groupRouter = createTRPCRouter({
getAll: permissionRequiredProcedure.requiresPermission("admin").query(async ({ ctx }) => { getAll: permissionRequiredProcedure.requiresPermission("admin").query(async ({ ctx }) => {
@@ -312,8 +312,8 @@ export const groupRouter = createTRPCRouter({
const permissions = [ const permissions = [
...new Set( ...new Set(
input.permissions.flatMap((permission): GroupPermissionKey[] => { input.permissions.flatMap((permission) => {
const parent = permission in createPermissionParents ? createPermissionParents[permission] : null; const parent = createPermissionParents.get(permission);
return parent ? [permission, parent] : [permission]; return parent ? [permission, parent] : [permission];
}), }),
), ),