From 7f7ee3263cd55ec30cc756921a14a711d84bc12b Mon Sep 17 00:00:00 2001 From: Thomas Camlong Date: Wed, 19 Aug 2026 09:44:50 +0200 Subject: [PATCH] fix(spotlight): show the app search group to app administrators app.search accepts app-modify-all or board-modify-all, but the spotlight group was only offered to board modifiers, so a user who administers apps could not search them. The two conditions now match. --- .../src/modes/app-integration-board/index.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/spotlight/src/modes/app-integration-board/index.tsx b/packages/spotlight/src/modes/app-integration-board/index.tsx index 5578bb648..a773923ef 100644 --- a/packages/spotlight/src/modes/app-integration-board/index.tsx +++ b/packages/spotlight/src/modes/app-integration-board/index.tsx @@ -17,10 +17,11 @@ export const appIntegrationBoardMode = { return groups; } - return groups.concat( - session.user.permissions.includes("board-modify-all") - ? [appsSearchGroup, integrationsSearchGroup] - : [integrationsSearchGroup], - ); + // Mirrors the gate on app.search: either permission may browse the app catalogue, so an app + // administrator without board access still gets the group instead of a FORBIDDEN response. + const canSearchApps = + session.user.permissions.includes("board-modify-all") || session.user.permissions.includes("app-modify-all"); + + return groups.concat(canSearchApps ? [appsSearchGroup, integrationsSearchGroup] : [integrationsSearchGroup]); }, } satisfies SearchMode;