From 5bc88eb4ee259d7ff708b47ce844235ee3fa0aa0 Mon Sep 17 00:00:00 2001 From: Thomas Camlong Date: Mon, 18 May 2026 15:19:11 +0200 Subject: [PATCH] fix: MissingSecretError type mismatch in onboard createIntegration mutation --- packages/api/src/router/onboard/onboard-router.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/api/src/router/onboard/onboard-router.ts b/packages/api/src/router/onboard/onboard-router.ts index 327a8f961..daec79ada 100644 --- a/packages/api/src/router/onboard/onboard-router.ts +++ b/packages/api/src/router/onboard/onboard-router.ts @@ -27,6 +27,8 @@ import { import type { WidgetKind } from "@homarr/definitions"; import { zodEnumFromArray } from "@homarr/validation/enums"; +import { TRPCError } from "@trpc/server"; + import { createTRPCRouter, onboardingProcedure, publicProcedure } from "../../trpc"; import { MissingSecretError, testConnectionAsync } from "../integration/integration-test-connection"; import { mapTestConnectionError } from "../integration/map-test-connection-error"; @@ -145,10 +147,12 @@ export const onboardRouter = createTRPCRouter({ kind: input.kind, secrets: input.secrets, }).catch((error) => { - if (error instanceof MissingSecretError) { - return { success: false as const, error }; - } - throw error; + if (!(error instanceof MissingSecretError)) throw error; + + throw new TRPCError({ + code: "BAD_REQUEST", + message: error.message, + }); }); if (!result.success) {