From 5af6ec349b24cd0ff8be1e8d6154df0301c0494a Mon Sep 17 00:00:00 2001 From: ajnart Date: Sat, 22 Aug 2026 15:26:22 +0200 Subject: [PATCH] test: align grid geometry expectations --- .../board/layout/test/board-lanes.spec.ts | 9 +++++++-- .../grid/test/grid-preview-geometry.spec.ts | 18 ++++++++++++------ .../grid/test/grid-resize-outline.spec.ts | 6 ++++-- 3 files changed, 23 insertions(+), 10 deletions(-) diff --git a/apps/nextjs/src/components/board/layout/test/board-lanes.spec.ts b/apps/nextjs/src/components/board/layout/test/board-lanes.spec.ts index 83058fd89..373a5ec6d 100644 --- a/apps/nextjs/src/components/board/layout/test/board-lanes.spec.ts +++ b/apps/nextjs/src/components/board/layout/test/board-lanes.spec.ts @@ -5,7 +5,12 @@ import { BoardMockBuilder } from "~/components/board/items/actions/test/mocks/bo import { ContainerSectionMockBuilder } from "~/components/board/items/actions/test/mocks/container-section-mock"; import { EmptySectionMockBuilder } from "~/components/board/items/actions/test/mocks/empty-section-mock"; import { ItemMockBuilder } from "~/components/board/items/actions/test/mocks/item-mock"; -import { getBoardLaneColumnCount, getInitialBoardLogicalHeight, getRootSectionForLane } from "../index"; +import { + getBoardLaneColumnCount, + getInitialBoardLogicalHeight, + getLogicalTrackSize, + getRootSectionForLane, +} from "../index"; describe("board lanes", () => { test("gutters consume columns from the main canvas", () => { @@ -126,6 +131,6 @@ describe("board lanes", () => { }, ]; - expect(getInitialBoardLogicalHeight(board, layoutId)).toBe(872); + expect(getInitialBoardLogicalHeight(board, layoutId)).toBe(getLogicalTrackSize(4)); }); }); diff --git a/apps/nextjs/src/components/board/sections/grid/test/grid-preview-geometry.spec.ts b/apps/nextjs/src/components/board/sections/grid/test/grid-preview-geometry.spec.ts index 9628eaf9a..edaf4c96d 100644 --- a/apps/nextjs/src/components/board/sections/grid/test/grid-preview-geometry.spec.ts +++ b/apps/nextjs/src/components/board/sections/grid/test/grid-preview-geometry.spec.ts @@ -1,5 +1,7 @@ import { beforeEach, describe, expect, test } from "vitest"; +import { getLogicalTrackSize, LOGICAL_GRID_PITCH } from "~/components/board/layout"; + import { createGridPreviewDomState, syncGridPreviewGeometry } from "../grid-preview-geometry"; describe("grid preview geometry", () => { @@ -25,8 +27,12 @@ describe("grid preview geometry", () => { expect(elements.get("active")?.hasAttribute("data-grid-preview")).toBe(false); expect(elements.get("active")?.getAttribute("data-dnd-active")).toBe("true"); - expect(elements.get("displaced")?.style.getPropertyValue("--board-grid-preview-x")).toBe("-448px"); - expect(elements.get("displaced")?.style.getPropertyValue("--board-grid-preview-y")).toBe("448px"); + expect(elements.get("displaced")?.style.getPropertyValue("--board-grid-preview-x")).toBe( + `${-2 * LOGICAL_GRID_PITCH}px`, + ); + expect(elements.get("displaced")?.style.getPropertyValue("--board-grid-preview-y")).toBe( + `${2 * LOGICAL_GRID_PITCH}px`, + ); expect(elements.get("displaced")?.dataset.gridX).toBe("0"); expect(elements.get("displaced")?.dataset.gridY).toBe("2"); @@ -57,10 +63,10 @@ describe("grid preview geometry", () => { const active = elements.get("active"); expect(active?.getAttribute("data-grid-preview")).toBe("true"); - expect(active?.style.getPropertyValue("--board-grid-preview-x")).toBe("224px"); - expect(active?.style.getPropertyValue("--board-grid-preview-y")).toBe("224px"); - expect(active?.style.getPropertyValue("--board-grid-preview-width")).toBe("648px"); - expect(active?.style.getPropertyValue("--board-grid-preview-height")).toBe("872px"); + expect(active?.style.getPropertyValue("--board-grid-preview-x")).toBe(`${LOGICAL_GRID_PITCH}px`); + expect(active?.style.getPropertyValue("--board-grid-preview-y")).toBe(`${LOGICAL_GRID_PITCH}px`); + expect(active?.style.getPropertyValue("--board-grid-preview-width")).toBe(`${getLogicalTrackSize(3)}px`); + expect(active?.style.getPropertyValue("--board-grid-preview-height")).toBe(`${getLogicalTrackSize(4)}px`); expect(active?.dataset.gridW).toBe("3"); expect(active?.dataset.gridH).toBe("4"); }); diff --git a/apps/nextjs/src/components/board/sections/grid/test/grid-resize-outline.spec.ts b/apps/nextjs/src/components/board/sections/grid/test/grid-resize-outline.spec.ts index 958558d3e..b5633d68d 100644 --- a/apps/nextjs/src/components/board/sections/grid/test/grid-resize-outline.spec.ts +++ b/apps/nextjs/src/components/board/sections/grid/test/grid-resize-outline.spec.ts @@ -1,5 +1,7 @@ import { afterEach, describe, expect, test, vi } from "vitest"; +import { getLogicalTrackSize } from "~/components/board/layout"; + import { createGridResizeOutlineController } from "../grid-resize-outline"; describe("grid resize outline", () => { @@ -28,8 +30,8 @@ describe("grid resize outline", () => { const outline = shell.querySelector("[data-grid-resize-outline]"); expect(outline?.style.left).toBe("0px"); expect(outline?.style.top).toBe("0px"); - expect(outline?.style.width).toBe("200px"); - expect(outline?.style.height).toBe("424px"); + expect(outline?.style.width).toBe(`${getLogicalTrackSize(1)}px`); + expect(outline?.style.height).toBe(`${getLogicalTrackSize(2)}px`); expect(outline?.dataset.gridResizeValid).toBe("false"); controller.schedule(null);