fix(tasks): remove trpc cron-job api on port 3002

apps/tasks/package.json

@@ -23,7 +23,6 @@
     "@homarr/auth": "workspace:^0.1.0",
     "@homarr/common": "workspace:^0.1.0",
     "@homarr/core": "workspace:^",
-    "@homarr/cron-job-api": "workspace:^0.1.0",
     "@homarr/cron-jobs": "workspace:^0.1.0",
     "@homarr/cron-jobs-core": "workspace:^0.1.0",
     "@homarr/db": "workspace:^0.1.0",

apps/tasks/src/job-manager.ts

@@ -1,128 +0,0 @@
-import { schedule, validate as validateCron } from "node-cron";
-
-import { createLogger } from "@homarr/core/infrastructure/logs";
-import type { IJobManager } from "@homarr/cron-job-api";
-import type { jobGroup as cronJobGroup, JobGroupKeys } from "@homarr/cron-jobs";
-import type { Database, InferInsertModel } from "@homarr/db";
-import { eq } from "@homarr/db";
-import { cronJobConfigurations } from "@homarr/db/schema";
-
-const logger = createLogger({ module: "jobManager" });
-
-export class JobManager implements IJobManager {
-  constructor(
-    private db: Database,
-    private jobGroup: typeof cronJobGroup,
-  ) {}
-
-  public async startAsync(name: JobGroupKeys): Promise<void> {
-    await this.jobGroup.startAsync(name);
-  }
-  public async triggerAsync(name: JobGroupKeys): Promise<void> {
-    await this.jobGroup.runManuallyAsync(name);
-  }
-  public async stopAsync(name: JobGroupKeys): Promise<void> {
-    await this.jobGroup.stopAsync(name);
-  }
-  public async updateIntervalAsync(name: JobGroupKeys, cron: string): Promise<void> {
-    logger.info("Updating cron job interval", { name, expression: cron });
-    const job = this.jobGroup.getJobRegistry().get(name);
-    if (!job) throw new Error(`Job ${name} not found`);
-    if (!validateCron(cron)) {
-      throw new Error(`Invalid cron expression: ${cron}`);
-    }
-    if (job.preventCustomInterval && cron !== job.cronExpression) {
-      throw new Error(`Custom cron expressions are not allowed for job ${name}`);
-    }
-
-    await this.updateConfigurationAsync(name, { cronExpression: cron });
-    await this.jobGroup.getTask(name)?.destroy();
-
-    this.jobGroup.setTask(
-      name,
-      schedule(cron, () => void job.executeAsync(), {
-        name,
-      }),
-    );
-    logger.info("Cron job interval updated", { name, expression: cron });
-  }
-  public async disableAsync(name: JobGroupKeys): Promise<void> {
-    logger.info("Disabling cron job", { name });
-    const job = this.jobGroup.getJobRegistry().get(name);
-    if (!job) throw new Error(`Job ${name} not found`);
-
-    await this.updateConfigurationAsync(name, { isEnabled: false });
-    await this.jobGroup.stopAsync(name);
-    logger.info("Cron job disabled", { name });
-  }
-  public async enableAsync(name: JobGroupKeys): Promise<void> {
-    logger.info("Enabling cron job", { name });
-    await this.updateConfigurationAsync(name, { isEnabled: true });
-    await this.jobGroup.startAsync(name);
-    logger.info("Cron job enabled", { name });
-  }
-
-  private async updateConfigurationAsync(
-    name: JobGroupKeys,
-    configuration: Omit<Partial<InferInsertModel<typeof cronJobConfigurations>>, "name">,
-  ) {
-    const existingConfig = await this.db.query.cronJobConfigurations.findFirst({
-      where: (table, { eq }) => eq(table.name, name),
-    });
-
-    logger.debug("Updating cron job configuration", {
-      name,
-      configuration: JSON.stringify(configuration),
-      exists: Boolean(existingConfig),
-    });
-
-    if (existingConfig) {
-      await this.db
-        .update(cronJobConfigurations)
-        // prevent updating the name, as it is the primary key
-        .set({ ...configuration, name: undefined })
-        .where(eq(cronJobConfigurations.name, name));
-      logger.debug("Cron job configuration updated", {
-        name,
-        configuration: JSON.stringify(configuration),
-      });
-      return;
-    }
-
-    const job = this.jobGroup.getJobRegistry().get(name);
-    if (!job) throw new Error(`Job ${name} not found`);
-
-    await this.db.insert(cronJobConfigurations).values({
-      name,
-      cronExpression: configuration.cronExpression ?? job.cronExpression,
-      isEnabled: configuration.isEnabled ?? true,
-    });
-    logger.debug("Cron job configuration updated", {
-      name,
-      configuration: JSON.stringify(configuration),
-    });
-  }
-
-  public async getAllAsync(): Promise<
-    {
-      name: JobGroupKeys;
-      cron: string;
-      preventManualExecution: boolean;
-      preventCustomInterval: boolean;
-      isEnabled: boolean;
-    }[]
-  > {
-    const configurations = await this.db.query.cronJobConfigurations.findMany();
-
-    return [...this.jobGroup.getJobRegistry().entries()].map(([name, job]) => {
-      const config = configurations.find((config) => config.name === name);
-      return {
-        name,
-        cron: config?.cronExpression ?? job.cronExpression,
-        preventManualExecution: job.preventManualExecution,
-        preventCustomInterval: job.preventCustomInterval,
-        isEnabled: config?.isEnabled ?? true,
-      };
-    });
-  }
-}

apps/tasks/src/main.ts

@@ -1,52 +1,12 @@
 // This import has to be the first import in the file so that the agent is overridden before any other modules are imported.
 import "./overrides";
 
-import type { FastifyTRPCPluginOptions } from "@trpc/server/adapters/fastify";
-import { fastifyTRPCPlugin } from "@trpc/server/adapters/fastify";
-import fastify from "fastify";
-
-import { createLogger } from "@homarr/core/infrastructure/logs";
-import { ErrorWithMetadata } from "@homarr/core/infrastructure/logs/error";
-import type { JobRouter } from "@homarr/cron-job-api";
-import { jobRouter } from "@homarr/cron-job-api";
-import { CRON_JOB_API_KEY_HEADER, CRON_JOB_API_PATH, CRON_JOB_API_PORT } from "@homarr/cron-job-api/constants";
 import { jobGroup } from "@homarr/cron-jobs";
-import { db } from "@homarr/db";
 
-import { JobManager } from "./job-manager";
 import { onStartAsync } from "./on-start";
 
-const logger = createLogger({ module: "tasksMain" });
-
-const server = fastify({
-  maxParamLength: 5000,
-});
-server.register(fastifyTRPCPlugin, {
-  prefix: CRON_JOB_API_PATH,
-  trpcOptions: {
-    router: jobRouter,
-    createContext: ({ req }) => ({
-      manager: new JobManager(db, jobGroup),
-      apiKey: req.headers[CRON_JOB_API_KEY_HEADER] as string | undefined,
-    }),
-    onError({ path, error }) {
-      logger.error(new ErrorWithMetadata("Error in tasks tRPC handler", { path }, { cause: error }));
-    },
-  } satisfies FastifyTRPCPluginOptions<JobRouter>["trpcOptions"],
-});
-
 void (async () => {
   await onStartAsync();
   await jobGroup.initializeAsync();
   await jobGroup.startAllAsync();
-
-  try {
-    await server.listen({ port: CRON_JOB_API_PORT });
-    logger.info("Tasks web server started successfully", { port: CRON_JOB_API_PORT });
-  } catch (err) {
-    logger.error(
-      new ErrorWithMetadata("Failed to start tasks web server", { port: CRON_JOB_API_PORT }, { cause: err }),
-    );
-    process.exit(1);
-  }
 })();