fix(custom-widgets): address final v2 review feedback (#6451)

apps/workshop/tests/workshop-contracts.mjs

@@ -9,7 +9,19 @@ if (typeof clientExport !== "string") throw new Error("Workshop client export is
 await access(resolve("packages/workshop", clientExport));
 
 const hook = await read("apps/workshop/pb_hooks/workshop.pb.js");
-await access(resolve("apps/workshop/pb_hooks/workshop-utils.js"));
+const hookUtils = await read("apps/workshop/pb_hooks/workshop-utils.js");
+const schema = await read("packages/workshop/src/schema.ts");
+const constantValue = (source, name) => {
+  const match = source.match(new RegExp(`(?:export )?const ${name} = ([\\d_]+)`));
+  if (!match?.[1]) throw new Error(`Workshop limit ${name} is missing or is not a numeric literal`);
+  return Number(match[1].replaceAll("_", ""));
+};
+if (constantValue(hookUtils, "MAX_CSS_LENGTH") !== constantValue(schema, "MAX_WORKSHOP_CSS_LENGTH")) {
+  throw new Error("PocketBase and shared Workshop CSS limits must match");
+}
+if (constantValue(hookUtils, "MAX_CONTENT_LENGTH") !== constantValue(schema, "MAX_WORKSHOP_CONTENT_LENGTH")) {
+  throw new Error("PocketBase and shared Workshop content limits must match");
+}
 if (!hook.includes("require(`${__hooks}/workshop-utils.js`)")) {
   throw new Error("Workshop handlers must load shared helpers inside their isolated PocketBase contexts");
 }
@@ -25,6 +37,7 @@ for (const required of [
   "workshop_migration_state",
   "addedUserFields",
   "CREATE TRIGGER submissions_revision_cas",
+  "NEW.expectedRevision != OLD.revision",
   "state.rateLimits.enabled",
   "users.passwordAuth = state.users.passwordAuth",
   "users.oauth2 = state.users.oauth2",

apps/workshop/tests/workshop-migration.mjs

@@ -125,7 +125,13 @@ migration.up(app);
 if (!collections.has("workshop_migration_state") || settings.rateLimits.enabled !== true) {
   throw new Error("Workshop migration did not capture state before applying changes");
 }
-if (!rawQueries.some((query) => query.includes("CREATE TRIGGER submissions_revision_cas"))) {
+if (
+  !rawQueries.some(
+    (query) =>
+      query.includes("CREATE TRIGGER submissions_revision_cas") &&
+      query.includes("NEW.expectedRevision != OLD.revision"),
+  )
+) {
   throw new Error("Workshop migration did not install the atomic submission revision guard");
 }
 migration.down(app);
@@ -145,4 +151,23 @@ for (const name of ["workshop_migration_state", "workshop_listings", "reports",
   if (collections.has(name)) throw new Error(`Rollback left collection ${name}`);
 }
 
+collections.clear();
+records.clear();
+rawQueries.length = 0;
+settings.rateLimits = structuredClone(original.rateLimits);
+
+migration.up(app);
+const bootstrappedUsers = collections.get("users");
+if (!bootstrappedUsers) throw new Error("Fresh migration did not create the users collection");
+migration.down(app);
+if (collections.get("users") !== bootstrappedUsers) {
+  throw new Error("Fresh rollback removed the users collection required by the bootstrap hook");
+}
+for (const name of ["workshop_migration_state", "workshop_listings", "reports", "comments", "votes", "submissions"]) {
+  if (collections.has(name)) throw new Error(`Fresh rollback left collection ${name}`);
+}
+if (JSON.stringify(settings.rateLimits) !== JSON.stringify(original.rateLimits)) {
+  throw new Error("Fresh rollback did not restore rate limits");
+}
+
 console.log("Workshop migration up/down restoration passed");