fix(custom-widgets): address final v2 review feedback (#6451)

This commit is contained in:
Thomas authored and GitHub committed 2026-07-23 02:11:32 +02:00
1 parent df967751f6
commit 4f6e335f72
20 files changed
+186 -92

No files matched your search

+1 -6
View File
@@ -7,11 +7,6 @@ const rejectRequest = (message) => {
throw new BadRequestError(message);
};
const requestBodyValue = (event, name) => {
const body = event.requestInfo().body;
return body && typeof body.get === "function" ? body.get(name) : body ? body[name] : undefined;
};
const validateWidgetManifest = (content) => {
let widget;
try {
@@ -87,7 +82,7 @@ const sendEmail = (app, recipientEmail, subject, text, html) => {
module.exports = {
emailTemplate,
escapeHtml,
requestBodyValue,
rejectRequest,
sendEmail,
validateAndNormalizeSubmission,
};
+5 -3
View File
@@ -15,20 +15,22 @@ onRecordCreateRequest((event) => {
const { validateAndNormalizeSubmission } = require(`${__hooks}/workshop-utils.js`);
validateAndNormalizeSubmission(event.record);
event.record.set("revision", 1);
event.record.set("expectedRevision", 0);
event.record.set("changelog", "");
event.record.set("outdated", false);
event.next();
}, "submissions");
onRecordUpdateRequest((event) => {
const { requestBodyValue, validateAndNormalizeSubmission } = require(`${__hooks}/workshop-utils.js`);
const { rejectRequest, validateAndNormalizeSubmission } = require(`${__hooks}/workshop-utils.js`);
const original = event.record.original();
const currentRevision = original.getInt("revision");
const expectedRevision = Number(requestBodyValue(event, "expectedRevision"));
if (!Number.isSafeInteger(expectedRevision) || expectedRevision !== currentRevision) {
const expectedRevision = event.record.getInt("expectedRevision");
if (!Number.isSafeInteger(expectedRevision) || expectedRevision < 1) {
rejectRequest("Submission changed since it was read");
}
validateAndNormalizeSubmission(event.record);
event.record.set("expectedRevision", expectedRevision);
event.record.set("revision", currentRevision + 1);
event.next();
}, "submissions");