fix(custom-widgets): address v2 merge review

packages/db/schema/sqlite.ts

@@ -3,7 +3,7 @@ import type { MantineSize } from "@mantine/core";
 import type { DayOfWeek } from "@mantine/dates";
 import { relations, sql } from "drizzle-orm";
 import type { AnySQLiteColumn } from "drizzle-orm/sqlite-core";
-import { blob, index, int, primaryKey, sqliteTable, text } from "drizzle-orm/sqlite-core";
+import { blob, foreignKey, index, int, primaryKey, sqliteTable, text } from "drizzle-orm/sqlite-core";
 
 import {
   backgroundImageAttachments,
@@ -192,8 +192,8 @@ export const integrations = sqliteTable(
     kind: text().$type<IntegrationKind>().notNull(),
     appId: text().references(() => apps.id, { onDelete: "set null" }),
   },
-  (integrations) => ({
-    kindIdx: index("integration__kind_idx").on(integrations.kind),
+  (table) => ({
+    kindIdx: index("integration__kind_idx").on(table.kind),
   }),
 );
 
@@ -485,6 +485,60 @@ export const onboarding = sqliteTable("onboarding", {
   previousStep: text().$type<OnboardingStep>(),
 });
 
+/**
+ * Read-only v1 definitions retained during the Custom JSX v2 upgrade.
+ * They remain separate so legacy code can never execute in the v2 runtime.
+ */
+export const legacyCustomWidgetDefinitions = sqliteTable(
+  "legacy_custom_widget_definition",
+  {
+    id: text().notNull().primaryKey(),
+    name: text().notNull(),
+    description: text(),
+    iconUrl: text(),
+    url: text().notNull(),
+    authType: text().notNull().default("none"),
+    headerName: text(),
+    method: text().notNull().default("GET"),
+    requestBody: text(),
+    displayType: text().notNull().default("singleValue"),
+    displayConfig: text().default(emptySuperJSON).notNull(),
+    enabled: int({ mode: "boolean" }).notNull().default(true),
+    createdAt: int({ mode: "timestamp" })
+      .notNull()
+      .default(sql`(unixepoch())`),
+    updatedAt: int({ mode: "timestamp" })
+      .notNull()
+      .default(sql`(unixepoch())`),
+    creatorId: text(),
+  },
+  (table) => ({
+    creatorFk: foreignKey({
+      columns: [table.creatorId],
+      foreignColumns: [users.id],
+      name: "legacy_cw_definition_creator_id_user_id_fk",
+    }).onDelete("set null"),
+  }),
+);
+
+export const legacyCustomWidgetSecrets = sqliteTable(
+  "legacy_custom_widget_secret",
+  {
+    kind: text().$type<CustomWidgetSecretKind>().notNull(),
+    encryptedValue: text("value").$type<`${string}.${string}`>().notNull(),
+    updatedAt: int({ mode: "timestamp" }).notNull(),
+    definitionId: text().notNull(),
+  },
+  (table) => ({
+    compoundKey: primaryKey({ columns: [table.definitionId, table.kind] }),
+    definitionFk: foreignKey({
+      columns: [table.definitionId],
+      foreignColumns: [legacyCustomWidgetDefinitions.id],
+      name: "legacy_cw_secret_definition_id_fk",
+    }).onDelete("cascade"),
+  }),
+);
+
 export const customWidgetDefinitions = sqliteTable("custom_widget_definition", {
   id: text().notNull().primaryKey(),
   name: text().notNull(),
@@ -513,14 +567,17 @@ export const customWidgetSecrets = sqliteTable(
     updatedAt: int({ mode: "timestamp" })
       .$onUpdateFn(() => new Date())
       .notNull(),
-    definitionId: text()
-      .notNull()
-      .references(() => customWidgetDefinitions.id, { onDelete: "cascade" }),
+    definitionId: text().notNull(),
   },
   (table) => ({
     compoundKey: primaryKey({
       columns: [table.definitionId, table.sourceId, table.kind],
     }),
+    definitionFk: foreignKey({
+      columns: [table.definitionId],
+      foreignColumns: [customWidgetDefinitions.id],
+      name: "cw_secret_definition_id_fk",
+    }).onDelete("cascade"),
   }),
 );
 
@@ -836,3 +893,18 @@ export const customWidgetSecretRelations = relations(customWidgetSecrets, ({ one
     references: [customWidgetDefinitions.id],
   }),
 }));
+
+export const legacyCustomWidgetDefinitionRelations = relations(legacyCustomWidgetDefinitions, ({ many, one }) => ({
+  secrets: many(legacyCustomWidgetSecrets),
+  creator: one(users, {
+    fields: [legacyCustomWidgetDefinitions.creatorId],
+    references: [users.id],
+  }),
+}));
+
+export const legacyCustomWidgetSecretRelations = relations(legacyCustomWidgetSecrets, ({ one }) => ({
+  definition: one(legacyCustomWidgetDefinitions, {
+    fields: [legacyCustomWidgetSecrets.definitionId],
+    references: [legacyCustomWidgetDefinitions.id],
+  }),
+}));