From 4676b181734d827d9e40e5e156d778e0fb4fcb59 Mon Sep 17 00:00:00 2001
From: ajnart <thomas@ajnart.dev>
Date: Tue, 25 Aug 2026 17:51:56 +0200
Subject: [PATCH] fix: stabilize e2e login hydration

---
 e2e/assistant-management.spec.ts |  9 ++-------
 e2e/lazy-widgets.spec.ts         | 11 ++---------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/e2e/assistant-management.spec.ts b/e2e/assistant-management.spec.ts
index 1aaf0042b..c97883e97 100644
--- a/e2e/assistant-management.spec.ts
+++ b/e2e/assistant-management.spec.ts
@@ -3,6 +3,7 @@ import { describe, test } from "vitest";
 
 import { createHomarrContainer } from "./shared/create-homarr-container";
 import { createSqliteDbFileAsync } from "./shared/e2e-db";
+import { loginAsync } from "./shared/login";
 import { seedAdminUserAsync } from "./shared/seed-admin-user";
 import * as sqliteSchema from "../packages/db/schema/sqlite";
 
@@ -40,13 +41,7 @@ describe("Assistant management", () => {
     const page = await context.newPage();
 
     try {
-      await page.goto(`${baseUrl}/auth/login`);
-      await page.getByLabel("Username").fill(adminCredentials.username);
-      await page.locator("#password").fill(adminCredentials.password);
-      await page.getByRole("button", { name: "Login" }).click();
-      await expect(page).not.toHaveURL(/\/auth\/login/, { timeout: 30_000 });
-
-      await page.goto(`${baseUrl}/manage/assistant`);
+      await loginAsync({ page, baseUrl, credentials: adminCredentials, destination: "/manage/assistant" });
       await expect(page.getByRole("heading", { name: "Assistant" })).toBeVisible();
       await expect(page.getByText("Connection ready")).toBeVisible();
       await expect(page.getByText("Encrypted API key saved")).toBeVisible();
diff --git a/e2e/lazy-widgets.spec.ts b/e2e/lazy-widgets.spec.ts
index d777ed0dc..4a595f754 100644
--- a/e2e/lazy-widgets.spec.ts
+++ b/e2e/lazy-widgets.spec.ts
@@ -8,6 +8,7 @@ import { describe, test } from "vitest";
 import * as sqliteSchema from "../packages/db/schema/sqlite";
 import { createHomarrContainer } from "./shared/create-homarr-container";
 import { createSqliteDbFileAsync } from "./shared/e2e-db";
+import { loginAsync } from "./shared/login";
 import { seedAdminUserAsync } from "./shared/seed-admin-user";
 
 const adminCredentials = {
@@ -116,15 +117,7 @@ describe("lazy widget application graph", () => {
     let releaseRefresh: (() => void) | undefined;
 
     try {
-      await page.goto(`${baseUrl}/auth/login`);
-      await page.getByLabel("Username").fill(adminCredentials.username);
-      await page.locator("#password").fill(adminCredentials.password);
-      const signedIn = page.waitForURL((url) => url.origin === baseUrl && url.pathname === "/", {
-        waitUntil: "commit",
-        timeout: 60_000,
-      });
-      await page.locator("css=button[type='submit']").click();
-      await signedIn;
+      await loginAsync({ page, baseUrl, credentials: adminCredentials });
 
       const visibleBoard = page.locator("[data-homarr-dev-benchmark-board]").filter({ visible: true }).first();
       await expect(visibleBoard).toBeVisible({ timeout: 30_000 });