From 45b3f2c08aee8e633965fa802fd284f9cee68823 Mon Sep 17 00:00:00 2001 From: Thomas Camlong Date: Mon, 3 Aug 2026 17:36:18 +0200 Subject: [PATCH] Revert "fix: allow [homarr_base] template variables in app href validation (#6508)" This reverts commit f1b7a5146ab7da4f5138c43bbc37a00d52d95b7c. --- packages/definitions/src/docs/homarr-docs-sitemap.ts | 1 - packages/validation/src/app.ts | 4 ---- 2 files changed, 5 deletions(-) diff --git a/packages/definitions/src/docs/homarr-docs-sitemap.ts b/packages/definitions/src/docs/homarr-docs-sitemap.ts index 7185a2fdd..22bc5f75b 100644 --- a/packages/definitions/src/docs/homarr-docs-sitemap.ts +++ b/packages/definitions/src/docs/homarr-docs-sitemap.ts @@ -119,7 +119,6 @@ export type HomarrDocumentationPath = | "/docs/tags/variables" | "/docs/tags/widgets" | "/docs/advanced/command-line" - | "/docs/advanced/command-line/development" | "/docs/advanced/command-line/fix-usernames" | "/docs/advanced/command-line/integrations" | "/docs/advanced/command-line/password-recovery" diff --git a/packages/validation/src/app.ts b/packages/validation/src/app.ts index e3b94218b..21a4335be 100644 --- a/packages/validation/src/app.ts +++ b/packages/validation/src/app.ts @@ -5,10 +5,6 @@ export const appHrefSchema = z .trim() .url() .regex(/^(?!javascript)[a-zA-Z]*:\/\//i) // javascript: is not allowed, i for case insensitive (so Javascript: is also not allowed) - .or(z.string().trim().includes("[homarr_base]")) - .or(z.string().trim().includes("[homarr_hostname]")) - .or(z.string().trim().includes("[homarr_domain]")) - .or(z.string().trim().includes("[homarr_protocol]")) .or(z.literal("")) .transform((value) => (value.length === 0 ? null : value)) .nullable();