fix: address CodeRabbit review — stream tee, cache guard, base64, layout fallback
- BoardLayoutFallback: use HomarrLogoWithTitle (no board context required) - integration-data-cache: guard cache.set with placeholder identity to prevent stale write-back after invalidation + test - next-cache-handler: memoize the promise (not resolved handler) to prevent concurrent Redis connections - redis-handler: tee ReadableStream before consuming in set(), hand fresh branch to each get() caller - redis-handler: base64-encode body instead of number[] (3-4x smaller)
This commit is contained in:
5 files changed
+58
-25
No files matched your search
@@ -1,21 +1,19 @@
|
||||
import type { CacheHandler } from "next/dist/server/lib/cache-handlers/types";
|
||||
|
||||
let handler: CacheHandler;
|
||||
|
||||
const getHandler = async (): Promise<CacheHandler> => {
|
||||
if (handler) return handler;
|
||||
let handlerPromise: Promise<CacheHandler> | undefined;
|
||||
|
||||
const createHandlerAsync = async (): Promise<CacheHandler> => {
|
||||
const useRedis = process.env.REDIS_HOST || process.env.REDIS_IS_EXTERNAL === "true";
|
||||
if (useRedis) {
|
||||
const { RedisCacheHandler } = await import("./redis-handler");
|
||||
handler = new RedisCacheHandler();
|
||||
} else {
|
||||
const { createDefaultCacheHandler } = await import("next/dist/server/lib/cache-handlers/default");
|
||||
handler = createDefaultCacheHandler(32 * 1024 * 1024);
|
||||
return new RedisCacheHandler();
|
||||
}
|
||||
return handler;
|
||||
const { createDefaultCacheHandler } = await import("next/dist/server/lib/cache-handlers/default");
|
||||
return createDefaultCacheHandler(32 * 1024 * 1024);
|
||||
};
|
||||
|
||||
const getHandler = (): Promise<CacheHandler> => (handlerPromise ??= createHandlerAsync());
|
||||
|
||||
export default {
|
||||
get: async (...args: Parameters<CacheHandler["get"]>) => (await getHandler()).get(...args),
|
||||
set: async (...args: Parameters<CacheHandler["set"]>) => (await getHandler()).set(...args),
|
||||
|
||||
Reference in new issue
Block a user