fix(mcp): honor configured OAuth base URL

This commit is contained in:
ajnart committed 2026-08-22 12:32:06 +02:00
1 parent 9b7a796934
commit 3ea74f12d2
9 files changed
+88 -12

No files matched your search

@@ -7,12 +7,13 @@ import { CallToolRequestSchema, ListToolsRequestSchema } from "@modelcontextprot
import { createTRPCContext, mcpRouter } from "@homarr/api/mcp";
import { API_KEY_HEADER_NAME, getSessionFromApiKeyAsync } from "@homarr/auth/api-key";
import { extractBaseUrlFromHeaders, removeTrailingSlash } from "@homarr/common";
import { removeTrailingSlash } from "@homarr/common";
import { ipAddressFromHeaders } from "@homarr/common/server";
import { createLogger } from "@homarr/core/infrastructure/logs";
import { db } from "@homarr/db";
import { getPackageVersion } from "~/versions/package-reader";
import { getMcpBaseUrl } from "../_base-url";
import { extractMcpTools } from "../_extract-tools";
const logger = createLogger({ module: "mcpRoute" });
@@ -264,7 +265,7 @@ const handler = async (req: NextRequest) => {
if (!apiKeyValue) {
recordAuthFailure(ipAddress);
const baseUrl = extractBaseUrlFromHeaders(req.headers);
const baseUrl = getMcpBaseUrl(req.headers);
const resourcePath = removeTrailingSlash(new URL(req.url).pathname);
return jsonErrorResponse(
401,
+8
View File
@@ -0,0 +1,8 @@
import type { ReadonlyHeaders } from "next/dist/server/web/spec-extension/adapters/headers";
import { extractBaseUrlFromHeaders, removeTrailingSlash } from "@homarr/common";
import { env } from "~/env";
export const getMcpBaseUrl = (headers: ReadonlyHeaders) =>
removeTrailingSlash(env.BASE_URL ?? extractBaseUrlFromHeaders(headers));
@@ -1,8 +1,8 @@
import type { NextRequest } from "next/server";
import { extractBaseUrlFromHeaders } from "@homarr/common";
import { auth } from "@homarr/auth/next";
import { getMcpBaseUrl } from "../../_base-url";
import { consumePendingAuth, createAuthCode, getClient, storePendingAuth } from "../_store";
export async function GET(req: NextRequest) {
@@ -138,7 +138,7 @@ export async function GET(req: NextRequest) {
);
}
const baseUrl = extractBaseUrlFromHeaders(req.headers);
const baseUrl = getMcpBaseUrl(req.headers);
const loginUrl = new URL("/auth/login", baseUrl);
loginUrl.searchParams.set("callbackUrl", `/api/mcp/oauth/authorize?pending=${id}`);
return Response.redirect(loginUrl.toString());
@@ -0,0 +1,60 @@
import { describe, expect, test, vi } from "vitest";
import { NextRequest } from "next/server";
vi.mock("~/env", () => ({ env: { BASE_URL: "https://homarr.example.com/" } }));
import { GET } from "./route";
const request = new NextRequest("http://internal-container:3000/well-known/oauth-protected-resource", {
headers: {
host: "internal-container:3000",
"x-forwarded-host": "untrusted.example.com",
"x-forwarded-proto": "http",
},
});
describe("MCP OAuth metadata", () => {
test("uses the configured public base URL for authorization server metadata", async () => {
const response = await GET(request, {
params: Promise.resolve({ path: ["oauth-authorization-server"] }),
});
await expect(response.json()).resolves.toMatchObject({
issuer: "https://homarr.example.com",
authorization_endpoint: "https://homarr.example.com/api/mcp/oauth/authorize",
});
});
test("preserves a path-inserted authorization server issuer", async () => {
const response = await GET(request, {
params: Promise.resolve({ path: ["oauth-authorization-server", "api", "mcp", "mcp"] }),
});
await expect(response.json()).resolves.toMatchObject({
issuer: "https://homarr.example.com/api/mcp/mcp",
authorization_endpoint: "https://homarr.example.com/api/mcp/oauth/authorize",
});
});
test("preserves the transport path in protected resource metadata", async () => {
const response = await GET(request, {
params: Promise.resolve({ path: ["oauth-protected-resource", "api", "mcp", "mcp"] }),
});
await expect(response.json()).resolves.toEqual({
resource: "https://homarr.example.com/api/mcp/mcp",
authorization_servers: ["https://homarr.example.com"],
});
});
test("returns the public origin for root protected resource metadata", async () => {
const response = await GET(request, {
params: Promise.resolve({ path: ["oauth-protected-resource"] }),
});
await expect(response.json()).resolves.toEqual({
resource: "https://homarr.example.com",
authorization_servers: ["https://homarr.example.com"],
});
});
});
@@ -1,6 +1,6 @@
import type { NextRequest } from "next/server";
import { extractBaseUrlFromHeaders } from "@homarr/common";
import { getMcpBaseUrl } from "~/app/api/mcp/_base-url";
const corsHeaders = {
"Access-Control-Allow-Origin": "*",
@@ -8,14 +8,16 @@ const corsHeaders = {
"Access-Control-Allow-Headers": "*",
};
export async function GET(_req: NextRequest, props: { params: Promise<{ path: string[] }> }) {
export async function GET(req: NextRequest, props: { params: Promise<{ path: string[] }> }) {
const [kind, ...rest] = (await props.params).path;
const baseUrl = extractBaseUrlFromHeaders(_req.headers);
const baseUrl = getMcpBaseUrl(req.headers);
const identifierPath = rest.join("/");
const identifier = identifierPath ? `${baseUrl}/${identifierPath}` : baseUrl;
if (kind === "oauth-authorization-server") {
return Response.json(
{
issuer: baseUrl,
issuer: identifier,
authorization_endpoint: `${baseUrl}/api/mcp/oauth/authorize`,
token_endpoint: `${baseUrl}/api/mcp/oauth/token`,
registration_endpoint: `${baseUrl}/api/mcp/oauth/register`,
@@ -30,10 +32,9 @@ export async function GET(_req: NextRequest, props: { params: Promise<{ path: st
}
if (kind === "oauth-protected-resource") {
const resourcePath = rest.join("/");
return Response.json(
{
resource: resourcePath ? `${baseUrl}/${resourcePath}` : baseUrl,
resource: identifier,
authorization_servers: [baseUrl],
},
{ headers: corsHeaders },
+2
View File
@@ -1,7 +1,9 @@
import { createBooleanSchema, createEnv } from "@homarr/core/infrastructure/env";
import { z } from "zod/v4";
export const env = createEnv({
server: {
BASE_URL: z.string().url().optional(),
UNSAFE_ENABLE_MOCK_INTEGRATION: createBooleanSchema(false),
DEMO_MODE: createBooleanSchema(false),
DEMO_READ_ONLY: createBooleanSchema(true),