fix(integrations): keep unifi-os-types client-safe

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
zacharyandClaude Opus 5 committed 2026-10-08 00:23:44 +02:00
1 parent 277fbb841e
commit 3125bcf400
5 files changed
+42 -20

No files matched your search

@@ -1,4 +1,7 @@
// @vitest-environment node
import { readFileSync } from "node:fs";
import { fileURLToPath } from "node:url";
import { describe, expect, test, vi } from "vitest";
vi.hoisted(() => {
@@ -147,6 +150,22 @@ describe("matchCloudSite", () => {
});
});
describe("client-safety", () => {
// `unifi-os-types.ts` is re-exported by `packages/integrations/src/types.ts`,
// which client components import (e.g. via the spotlight search group). An
// import of `@homarr/common/server` here drags `ioredis` — and transitively
// Node's `dns` module — into the browser bundle and breaks `pnpm dev`/build.
// Only a source-text check catches this: a type-only "does it compile" check
// would not, since the breakage is a bundler resolution failure, not a type
// error. This regression guard is what would have caught the original bug.
test("does not import @homarr/common/server", () => {
const path = fileURLToPath(new URL("../unifi-os-types.ts", import.meta.url));
const source = readFileSync(path, "utf-8");
expect(source).not.toContain("@homarr/common/server");
});
});
describe("unifiOsClientSchema", () => {
test("keeps fields the published OpenAPI does not document", () => {
const parsed = unifiOsClientSchema.parse({