From 2e99b424fde42f9b1d1c84d86109eec7565d8de1 Mon Sep 17 00:00:00 2001 From: Thomas Camlong Date: Mon, 17 Aug 2026 17:20:54 +0200 Subject: [PATCH] Revert "fix: uncommitted review fixes" This reverts commit 3603d0393c1593f8515ea68691e5c4f577f03e9e. --- apps/docs/docs/management/api/index.mdx | 4 ---- .../users/groups/[id]/permissions/_group-permission-form.tsx | 4 ---- packages/spotlight/src/modes/app-integration-board/index.tsx | 2 +- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/apps/docs/docs/management/api/index.mdx b/apps/docs/docs/management/api/index.mdx index 472e472f2..82fde7057 100644 --- a/apps/docs/docs/management/api/index.mdx +++ b/apps/docs/docs/management/api/index.mdx @@ -63,10 +63,6 @@ curl -H 'ApiKey: .' http://localhost:7575/api/health/live curl -H 'ApiKey: .' http://localhost:7575/api/trpc/app.all ``` -### App Endpoint Permissions - -The app endpoints (`/api/apps/paginated`, `/api/apps`, `/api/apps/search` and the corresponding tRPC procedures and MCP tools) require the `app-modify-all` permission. API keys inherit the permissions of the user who created them, so a key can only list apps when its owner can manage apps. Endpoints that only read app metadata for board placement (`/api/apps/selectable`, `/api/apps/{id}`) remain available to signed-in users without this permission. - ### Use Cases API key authentication enables programmatic access for: diff --git a/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/permissions/_group-permission-form.tsx b/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/permissions/_group-permission-form.tsx index 1b88e2124..e91ec1d02 100644 --- a/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/permissions/_group-permission-form.tsx +++ b/apps/nextjs/src/app/[locale]/manage/users/groups/[id]/permissions/_group-permission-form.tsx @@ -132,10 +132,6 @@ export const MatrixImpliedHint = ({ category, permissionLabels }: MatrixImpliedH const form = useFormContext(); const tPermissions = useScopedI18n("group.permission"); - if (category === "admin") { - return null; - } - const level = getMatrixLevel(form.getValues(), category); if (level === 0) { return null; diff --git a/packages/spotlight/src/modes/app-integration-board/index.tsx b/packages/spotlight/src/modes/app-integration-board/index.tsx index 6ce2381fe..5578bb648 100644 --- a/packages/spotlight/src/modes/app-integration-board/index.tsx +++ b/packages/spotlight/src/modes/app-integration-board/index.tsx @@ -18,7 +18,7 @@ export const appIntegrationBoardMode = { } return groups.concat( - session.user.permissions.includes("app-modify-all") || session.user.permissions.includes("board-modify-all") + session.user.permissions.includes("board-modify-all") ? [appsSearchGroup, integrationsSearchGroup] : [integrationsSearchGroup], );