fix: address board grid review
This commit is contained in:
1 parent
cddae6719e
commit
28ac23e66b
51 files changed
+647
-278
No files matched your search
@@ -465,7 +465,6 @@ describe("Board grid", () => {
|
||||
await expect(containerSection.locator("xpath=ancestor::aside[1]")).toHaveAttribute("data-board-gutter", "left");
|
||||
await editToggle.click();
|
||||
await expect(page.locator(`[data-grid-runtime="${gridRuntimeMarker}"]`)).toHaveCount(3);
|
||||
const mainGridBox = await expectBoundingBoxAsync(mainGrid);
|
||||
await dragHandleToGridPositionAsync(page, containerGrip, containerSection, mainGrid, 2, 0, canvasScale);
|
||||
await expect(containerSection.locator("xpath=ancestor::*[@data-grid-section-id][1]")).toHaveAttribute(
|
||||
"data-grid-section-id",
|
||||
@@ -481,6 +480,7 @@ describe("Board grid", () => {
|
||||
await secondItem.locator("[data-grid-item-content]").evaluate((element) => {
|
||||
element.setAttribute("data-e2e-portal-instance", "second-item-content");
|
||||
});
|
||||
const mainGridBox = await expectBoundingBoxAsync(mainGrid);
|
||||
await dragLocatorToAsync(
|
||||
page,
|
||||
secondItem,
|
||||
|
||||
@@ -10,8 +10,9 @@ export const createHomarrContainer = (
|
||||
};
|
||||
} = {},
|
||||
) => {
|
||||
const image = process.env.HOMARR_E2E_IMAGE?.trim() || "homarr-e2e";
|
||||
if (!process.env.CI) {
|
||||
const configuredImage = process.env.HOMARR_E2E_IMAGE?.trim();
|
||||
const image = configuredImage || "homarr-e2e";
|
||||
if (!process.env.CI && !configuredImage) {
|
||||
throw new Error(`This test should only be run in CI or with a local Homarr image (configured: '${image}')`);
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user