fix: address onboarding review feedback
This commit is contained in:
1 parent
dc71084323
commit
2566be2838
72 files changed
+7783
-280
No files matched your search
@@ -51,7 +51,7 @@ describe("parseContainerLabels", () => {
|
||||
"remote:2375",
|
||||
),
|
||||
).toMatchObject({
|
||||
sourceId: "docker:remote:2375:container-1",
|
||||
sourceId: "docker:remote%3A2375:container-1",
|
||||
name: "Jellyfin",
|
||||
group: "Media",
|
||||
href: "http://jellyfin:8096",
|
||||
@@ -59,6 +59,21 @@ describe("parseContainerLabels", () => {
|
||||
});
|
||||
});
|
||||
|
||||
it("keeps host and service identifiers unambiguous", () => {
|
||||
const first = parseContainerLabels(
|
||||
container({ "homarr.name": "Service", "homarr.href": "http://service", "homarr.id": "service" }),
|
||||
"remote:2375",
|
||||
);
|
||||
const second = parseContainerLabels(
|
||||
container({ "homarr.name": "Service", "homarr.href": "http://service", "homarr.id": "2375:service" }),
|
||||
"remote",
|
||||
);
|
||||
|
||||
expect(first?.sourceId).toBe("docker:remote%3A2375:service");
|
||||
expect(second?.sourceId).toBe("docker:remote:2375%3Aservice");
|
||||
expect(first?.sourceId).not.toBe(second?.sourceId);
|
||||
});
|
||||
|
||||
it("keeps a labeled service without a group for root placement", () => {
|
||||
expect(
|
||||
parseContainerLabels(
|
||||
|
||||
Reference in new issue
Block a user