fix(security): remove salt from database (#5412)
This commit is contained in:
1 parent
41a03ef4e0
commit
2454cac7be
24 files changed
+6198
-81
No files matched your search
@@ -4,7 +4,7 @@ import { createId } from "@homarr/common";
|
||||
import { users } from "@homarr/db/schema";
|
||||
import { createDb } from "@homarr/db/test";
|
||||
|
||||
import { createSaltAsync, hashPasswordAsync } from "../../security";
|
||||
import { hashPasswordAsync } from "../../security";
|
||||
import { authorizeWithBasicCredentialsAsync } from "../credentials/authorization/basic-authorization";
|
||||
|
||||
const defaultUserId = createId();
|
||||
@@ -13,12 +13,10 @@ describe("authorizeWithBasicCredentials", () => {
|
||||
test("should authorize user with correct credentials", async () => {
|
||||
// Arrange
|
||||
const db = createDb();
|
||||
const salt = await createSaltAsync();
|
||||
await db.insert(users).values({
|
||||
id: defaultUserId,
|
||||
name: "test",
|
||||
salt,
|
||||
password: await hashPasswordAsync("test", salt),
|
||||
password: await hashPasswordAsync("test"),
|
||||
});
|
||||
|
||||
// Act
|
||||
@@ -34,12 +32,10 @@ describe("authorizeWithBasicCredentials", () => {
|
||||
test("should not authorize user with incorrect credentials", async () => {
|
||||
// Arrange
|
||||
const db = createDb();
|
||||
const salt = await createSaltAsync();
|
||||
await db.insert(users).values({
|
||||
id: defaultUserId,
|
||||
name: "test",
|
||||
salt,
|
||||
password: await hashPasswordAsync("test", salt),
|
||||
password: await hashPasswordAsync("test"),
|
||||
});
|
||||
|
||||
// Act
|
||||
@@ -55,12 +51,10 @@ describe("authorizeWithBasicCredentials", () => {
|
||||
test("should not authorize user with incorrect username", async () => {
|
||||
// Arrange
|
||||
const db = createDb();
|
||||
const salt = await createSaltAsync();
|
||||
await db.insert(users).values({
|
||||
id: defaultUserId,
|
||||
name: "test",
|
||||
salt,
|
||||
password: await hashPasswordAsync("test", salt),
|
||||
password: await hashPasswordAsync("test"),
|
||||
});
|
||||
|
||||
// Act
|
||||
|
||||
Reference in new issue
Block a user