From 0d1dd02184863e9de4ce6e29c24ad98775b51c77 Mon Sep 17 00:00:00 2001 From: ajnart Date: Sat, 8 Aug 2026 12:34:10 +0200 Subject: [PATCH] fix: address mobile board review --- .../board/mobile/mobile-board.module.css | 5 ++- .../components/board/mobile/mobile-board.tsx | 32 ++++++++++--------- packages/db/migrations/seed.spec.ts | 2 +- .../integrations/test/home-assistant.spec.ts | 2 ++ 4 files changed, 24 insertions(+), 17 deletions(-) diff --git a/apps/nextjs/src/components/board/mobile/mobile-board.module.css b/apps/nextjs/src/components/board/mobile/mobile-board.module.css index 7dfa65cc2..4a243dd04 100644 --- a/apps/nextjs/src/components/board/mobile/mobile-board.module.css +++ b/apps/nextjs/src/components/board/mobile/mobile-board.module.css @@ -1,5 +1,8 @@ -.grid { +.container { container-type: inline-size; +} + +.grid { display: grid; grid-template-columns: repeat(var(--mobile-column-count), minmax(0, 1fr)); grid-auto-flow: row; diff --git a/apps/nextjs/src/components/board/mobile/mobile-board.tsx b/apps/nextjs/src/components/board/mobile/mobile-board.tsx index aa06a521f..20e4b9445 100644 --- a/apps/nextjs/src/components/board/mobile/mobile-board.tsx +++ b/apps/nextjs/src/components/board/mobile/mobile-board.tsx @@ -32,21 +32,23 @@ export const MobileBoard = () => { refs: { wrapper: wrapperRef, items: itemRefs, gridstack: gridstackRef }, }} > - - {items.map((item) => ( - - - - ))} + + + {items.map((item) => ( + + + + ))} + diff --git a/packages/db/migrations/seed.spec.ts b/packages/db/migrations/seed.spec.ts index 802fd6559..0e0c49acc 100644 --- a/packages/db/migrations/seed.spec.ts +++ b/packages/db/migrations/seed.spec.ts @@ -49,7 +49,7 @@ describe("automatic mobile layout upgrade default", () => { test.each([ { boardId: "board", name: "Phone", breakpoint: 0 }, { boardId: "board", name: "Base", breakpoint: 480 }, - ])("preserves legacy mode for a noncanonical saved layout", (existingLayout) => { + ])("preserves legacy mode for a noncanonical saved layout $name/$breakpoint", (existingLayout) => { expect(shouldEnableAutomaticMobileLayoutForUpgrade([existingLayout])).toBe(false); }); diff --git a/packages/integrations/test/home-assistant.spec.ts b/packages/integrations/test/home-assistant.spec.ts index 5dc2be90e..788d6a666 100644 --- a/packages/integrations/test/home-assistant.spec.ts +++ b/packages/integrations/test/home-assistant.spec.ts @@ -88,10 +88,12 @@ const waitForHomeAssistantAsync = async (container: StartedTestContainer) => { try { const response = await fetch(url, { headers: { Authorization: `Bearer ${DEFAULT_API_KEY}` }, + signal: AbortSignal.timeout(500), }); if (response.ok) return; } catch { // Home Assistant is still restarting. + continue; } await new Promise((resolve) => setTimeout(resolve, 500));